Skip to content

gh-95591: enum: _FlagTests were never run #96475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 1, 2022

_FlagTests were unused. But, I suppose they should be used as a mixing for flag test cases.
So, they are now!

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Sep 1, 2022
@ethanfurman ethanfurman self-assigned this Sep 1, 2022
@ethanfurman ethanfurman merged commit 9b58eaf into python:main Sep 20, 2022
@ethanfurman ethanfurman added the needs backport to 3.11 only security fixes label Sep 20, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 20, 2022
@bedevere-bot
Copy link

GH-96976 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2022
(cherry picked from commit 9b58eaf)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Sep 20, 2022
(cherry picked from commit 9b58eaf)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants