Skip to content

[Enum] Remove unused code from test_enum.py #96986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

[Enum] Remove unused code from test_enum.py #96986

merged 1 commit into from
Dec 7, 2022

Conversation

sobolevn
Copy link
Member

While reading #96475 I found that there are some unused definitions on test_enum.py that should be removed.

I am not going to open an issue about that, because it is a test-only minor detail 👍

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 21, 2022
ethanfurman
ethanfurman reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to look more closely at the two _dir entries and make sure they shouldn't be used.

@sobolevn
Copy link
Member Author

They might be. I was in doubt about them. But these lines look like they do something very similar: https://github.com/python/cpython/pull/96986/files#diff-8467f9fbbff81abf26d87a8dbbf0e0c866157971948010e48cc73539251a9e4cL4519-L4525

@ethanfurman ethanfurman merged commit 889b0b9 into python:main Dec 7, 2022
@ethanfurman ethanfurman self-assigned this Dec 7, 2022
@ethanfurman ethanfurman added the 3.12 only security fixes label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman left review comments

Assignees

@ethanfurman ethanfurman

Labels
3.12 only security fixes skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @ethanfurman @bedevere-bot