-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fixes RTD #11419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes RTD #11419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can we make this use docs/requirements-docs.txt
? I don't have the permission to change the RTD to run on PR, but that should be fine since we ensure docs build with
mypy/.github/workflows/docs.yml
Line 19 in 3f43c83
TOXENV: docs |
@hauntsaninja oh, I was not aware of this file. Done! By the way, thanks a lot for reviewing / merging so many PRs! It made me happy 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I suspect the command that gets run will be slightly different from tox -e docs
and whatever RTD does right now, but maybe we just try this and see what happens
Looks like it worked! https://readthedocs.org/projects/mypy/builds/15143406/ |
This was added in python#11419 to fix python#11412 However, the presence of this file also configured mypyc's RTD. See python#901 I recently acquired access to mypy's RTD, so I think I can fix without this configuration file.
This was added in python#11419 to fix python#11412 However, the presence of this file also configured mypyc's RTD. See python#901 I recently acquired access to mypy's RTD, so I think I can fix without this configuration file. Co-authored-by: hauntsaninja <>
It passes locally:
Closes #11412
We can also enable "build PR branches" on RTD, if it is not enabled right now.
Checkbox:

Docs: https://docs.readthedocs.io/en/stable/pull-requests.html and https://docs.readthedocs.io/en/stable/development/design/pr-builder.html
I cannot do that myself 🙂