Skip to content

Fixes RTD #11419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Fixes RTD #11419

merged 2 commits into from
Oct 31, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 31, 2021

It passes locally:

» make html         
sphinx-build -b html -d build/doctrees   source build/html
Running Sphinx v4.2.0
making output directory... done
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
loading intersphinx inventory from https://six.readthedocs.io/objects.inv...
loading intersphinx inventory from http://www.attrs.org/en/stable/objects.inv...
loading intersphinx inventory from http://docs.cython.org/en/latest/objects.inv...
loading intersphinx inventory from https://monkeytype.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from https://setuptools.readthedocs.io/en/latest/objects.inv...
intersphinx inventory has moved: http://www.attrs.org/en/stable/objects.inv -> https://www.attrs.org/en/stable/objects.inv
intersphinx inventory has moved: https://setuptools.readthedocs.io/en/latest/objects.inv -> https://setuptools.pypa.io/en/latest/objects.inv
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 37 source files that are out of date
updating environment: [new config] 37 added, 0 changed, 0 removed
reading sources... [100%] type_narrowing                                              
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] type_narrowing                                               
generating indices... genindex done
writing additional pages... search done
copying static files... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded.

The HTML pages are in build/html.

Build finished. The HTML pages are in build/html.

Closes #11412

We can also enable "build PR branches" on RTD, if it is not enabled right now.

Checkbox:
Снимок экрана 2021-10-31 в 21 08 55

Docs: https://docs.readthedocs.io/en/stable/pull-requests.html and https://docs.readthedocs.io/en/stable/development/design/pr-builder.html

I cannot do that myself 🙂

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can we make this use docs/requirements-docs.txt? I don't have the permission to change the RTD to run on PR, but that should be fine since we ensure docs build with

TOXENV: docs

@sobolevn
Copy link
Member Author

@hauntsaninja oh, I was not aware of this file. Done!

By the way, thanks a lot for reviewing / merging so many PRs! It made me happy 👏

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suspect the command that gets run will be slightly different from tox -e docs and whatever RTD does right now, but maybe we just try this and see what happens

@hauntsaninja hauntsaninja merged commit 06c7433 into python:master Oct 31, 2021
@sobolevn
Copy link
Member Author

Looks like it worked! https://readthedocs.org/projects/mypy/builds/15143406/

@sobolevn sobolevn mentioned this pull request Oct 31, 2021
hauntsaninja pushed a commit to hauntsaninja/mypy that referenced this pull request Nov 1, 2021
This was added in python#11419 to fix python#11412

However, the presence of this file also configured mypyc's RTD. See python#901

I recently acquired access to mypy's RTD, so I think I can fix without
this configuration file.
hauntsaninja added a commit that referenced this pull request Nov 1, 2021
This was added in #11419 to fix #11412

However, the presence of this file also configured mypyc's RTD. See #901

I recently acquired access to mypy's RTD, so I think I can fix without
this configuration file.

Co-authored-by: hauntsaninja <>
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
This was added in python#11419 to fix python#11412

However, the presence of this file also configured mypyc's RTD. See python#901

I recently acquired access to mypy's RTD, so I think I can fix without
this configuration file.

Co-authored-by: hauntsaninja <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy ReadTheDocs build is failing
2 participants