Skip to content

feat: dynamic shape support for squeeze ops #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

keehyuna
Copy link
Collaborator

Description

It seems full dynamic shape for squeeze is not supported because data-dependent shape is used as input.
add_non_zero() was used to get dims to remove and it's result is used for reshape of input.

2cf4eaa#diff-7e6d7566192094882e7d98bfd423d08f49cf2d334c15cd3db12f4385ba82d3a1R51-R115

If dims for squeeze are static shape, operation is successful.
shape of x = (1, -1, 1, -1, 1)
torch.ops.aten.squeeze.dims(x, (0, 4))

If dims for squeeze are dynamic shape, there will be assert()
shape of x = (1, -1, 1, -1, 1)
torch.ops.aten.squeeze.dims(x, (0, 1))
AssertionError: We don't support squeeze dynamic dim.

More than one dynamic dim can be used if they are not squeezed.

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@keehyuna keehyuna self-assigned this Jul 10, 2024
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jul 10, 2024
@github-actions github-actions bot requested a review from narendasan July 10, 2024 14:25
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although this is not a part of this PR, can you rename the variable in this for loop ?

@peri044 peri044 merged commit 0d4af77 into pytorch:main Jul 15, 2024
36 of 61 checks passed
@keehyuna keehyuna deleted the squeeze_dynamic_shape branch August 19, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants