Skip to content

fix(//py): Fix trtorch.Device alternate contructor options #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix(//py): Fix trtorch.Device alternate contructor options #635

merged 1 commit into from
Sep 24, 2021

Conversation

narendasan
Copy link
Collaborator

Description

There were issues setting fields of trtorch.Device via
kwargs, this patch should resolve those and verify that they
work

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan narendasan added the release: patch This change needs to go out as a patch to the current version label Sep 23, 2021
@narendasan narendasan requested a review from peri044 September 23, 2021 20:28
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: tests Issues re: Tests labels Sep 23, 2021
@narendasan
Copy link
Collaborator Author

@peri044 Can you review this quickly it needs to get into the patch release with the module fallback fix

github-actions[bot]
github-actions bot requested changes Sep 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

Reformatting /workspace/py/trtorch/Input.py
Reformatting /workspace/py/trtorch/__init__.py
Reformatting /workspace/py/trtorch/_types.py
Reformatting /workspace/py/trtorch/ptq.py
Reformatting /workspace/py/trtorch/logging.py
Reformatting /workspace/py/trtorch/_compile_spec.py
Reformatting /workspace/py/trtorch/Device.py
Reformatting /workspace/py/trtorch/_compiler.py
Reformatting /workspace/py/setup.py
Reformatting /workspace/tests/py/test_ptq_trt_calibrator.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_to_backend_api.py
Reformatting /workspace/tests/py/test_ptq_to_backend.py
Reformatting /workspace/tests/py/test_ptq_dataloader_calibrator.py
Reformatting /workspace/tests/modules/hub.py
--- /workspace/tests/py/test_api.py	(original)
+++ /workspace/tests/py/test_api.py	(reformatted)
@@ -218,6 +218,7 @@
        color = trtorch.logging.get_is_colored_output_on()
        self.assertTrue(color)

+
class TestDevice(unittest.TestCase):

    def test_from_string_constructor(self):
@@ -263,7 +264,7 @@
        device = trtorch.Device._from_torch_device(torch.device("cuda:0"))
        self.assertEqual(device.device_type, trtorch.DeviceType.GPU)
        self.assertEqual(device.gpu_id, 0)
-    
+

def test_suite():
    suite = unittest.TestSuite()
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/py/test_qat_trt_accuracy.py
Reformatting /workspace/tests/py/test_trt_intercompatability.py
Reformatting /workspace/tests/py/test_api.py
ERROR: Some files do not conform to style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot requested changes Sep 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

Reformatting /workspace/py/trtorch/Input.py
Reformatting /workspace/py/trtorch/__init__.py
Reformatting /workspace/py/trtorch/_types.py
Reformatting /workspace/py/trtorch/ptq.py
Reformatting /workspace/py/trtorch/logging.py
Reformatting /workspace/py/trtorch/_compile_spec.py
Reformatting /workspace/py/trtorch/Device.py
Reformatting /workspace/py/trtorch/_compiler.py
Reformatting /workspace/py/setup.py
--- /workspace/tests/py/test_api.py	(original)
+++ /workspace/tests/py/test_api.py	(reformatted)
@@ -218,6 +218,7 @@
        color = trtorch.logging.get_is_colored_output_on()
        self.assertTrue(color)

+
class TestDevice(unittest.TestCase):

    def test_from_string_constructor(self):
@@ -263,7 +264,7 @@
        device = trtorch.Device._from_torch_device(torch.device("cuda:0"))
        self.assertEqual(device.device_type, trtorch.DeviceType.GPU)
        self.assertEqual(device.gpu_id, 0)
-    
+

def test_suite():
    suite = unittest.TestSuite()
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_trt_intercompatability.py
Reformatting /workspace/tests/py/test_api.py
Reformatting /workspace/tests/py/test_ptq_trt_calibrator.py
Reformatting /workspace/tests/py/test_qat_trt_accuracy.py
Reformatting /workspace/tests/py/test_to_backend_api.py
Reformatting /workspace/tests/py/test_ptq_to_backend.py
Reformatting /workspace/tests/py/test_ptq_dataloader_calibrator.py
Reformatting /workspace/tests/modules/hub.py
ERROR: Some files do not conform to style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot requested changes Sep 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

Reformatting /workspace/py/trtorch/Input.py
Reformatting /workspace/py/trtorch/__init__.py
Reformatting /workspace/py/trtorch/_types.py
Reformatting /workspace/py/trtorch/ptq.py
Reformatting /workspace/py/trtorch/logging.py
Reformatting /workspace/py/trtorch/_compile_spec.py
Reformatting /workspace/py/trtorch/Device.py
Reformatting /workspace/py/trtorch/_compiler.py
Reformatting /workspace/py/setup.py
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_to_backend_api.py
Reformatting /workspace/tests/py/test_ptq_to_backend.py
Reformatting /workspace/tests/py/test_ptq_dataloader_calibrator.py
Reformatting /workspace/tests/modules/hub.py
--- /workspace/tests/py/test_api.py	(original)
+++ /workspace/tests/py/test_api.py	(reformatted)
@@ -218,6 +218,7 @@
        color = trtorch.logging.get_is_colored_output_on()
        self.assertTrue(color)

+
class TestDevice(unittest.TestCase):

    def test_from_string_constructor(self):
@@ -263,7 +264,7 @@
        device = trtorch.Device._from_torch_device(torch.device("cuda:0"))
        self.assertEqual(device.device_type, trtorch.DeviceType.GPU)
        self.assertEqual(device.gpu_id, 0)
-    
+

def test_suite():
    suite = unittest.TestSuite()
Reformatting /workspace/tests/py/test_ptq_trt_calibrator.py
Reformatting /workspace/tests/py/test_qat_trt_accuracy.py
Reformatting /workspace/tests/py/test_trt_intercompatability.py
Reformatting /workspace/tests/py/test_api.py
ERROR: Some files do not conform to style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@narendasan
Copy link
Collaborator Author

Also I need to rebase this and the module fallback changes on the 0.4.0 tag

peri044
peri044 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests pass

@narendasan
Copy link
Collaborator Author

(Also we need to update this branch to 1.9.1)

github-actions[bot]
github-actions bot approved these changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot requested changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

Reformatting /workspace/py/trtorch/Input.py
Reformatting /workspace/py/trtorch/__init__.py
Reformatting /workspace/py/trtorch/_types.py
Reformatting /workspace/py/trtorch/ptq.py
Reformatting /workspace/py/trtorch/logging.py
Reformatting /workspace/py/trtorch/_compile_spec.py
Reformatting /workspace/py/trtorch/Device.py
Reformatting /workspace/py/trtorch/_compiler.py
Reformatting /workspace/py/setup.py
Reformatting /workspace/tests/py/test_ptq_trt_calibrator.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_to_backend_api.py
Reformatting /workspace/tests/py/test_ptq_to_backend.py
Reformatting /workspace/tests/py/test_ptq_dataloader_calibrator.py
Reformatting /workspace/tests/modules/hub.py
--- /workspace/tests/py/test_api.py	(original)
+++ /workspace/tests/py/test_api.py	(reformatted)
@@ -218,6 +218,7 @@
        color = trtorch.logging.get_is_colored_output_on()
        self.assertTrue(color)

+
class TestDevice(unittest.TestCase):

    def test_from_string_constructor(self):
@@ -263,7 +264,7 @@
        device = trtorch.Device._from_torch_device(torch.device("cuda:0"))
        self.assertEqual(device.device_type, trtorch.DeviceType.GPU)
        self.assertEqual(device.gpu_id, 0)
-    
+

def test_suite():
    suite = unittest.TestSuite()
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/py/test_qat_trt_accuracy.py
Reformatting /workspace/tests/py/test_trt_intercompatability.py
Reformatting /workspace/tests/py/test_api.py
ERROR: Some files do not conform to style guidelines

@narendasan
fix(//py): Fix trtorch.Device alternate contructor options
fa08311 
There were issues setting fields of trtorch.Device via
kwargs, this patch should resolve those and verify that they
work

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
github-actions[bot]
github-actions bot requested changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

Reformatting /workspace/py/trtorch/Input.py
Reformatting /workspace/py/trtorch/__init__.py
Reformatting /workspace/py/trtorch/_types.py
Reformatting /workspace/py/trtorch/ptq.py
Reformatting /workspace/py/trtorch/logging.py
Reformatting /workspace/py/trtorch/_compile_spec.py
Reformatting /workspace/py/trtorch/Device.py
Reformatting /workspace/py/trtorch/_compiler.py
Reformatting /workspace/py/setup.py
--- /workspace/tests/py/test_api.py	(original)
+++ /workspace/tests/py/test_api.py	(reformatted)
@@ -218,6 +218,7 @@
        color = trtorch.logging.get_is_colored_output_on()
        self.assertTrue(color)

+
class TestDevice(unittest.TestCase):

    def test_from_string_constructor(self):
@@ -263,7 +264,7 @@
        device = trtorch.Device._from_torch_device(torch.device("cuda:0"))
        self.assertEqual(device.device_type, trtorch.DeviceType.GPU)
        self.assertEqual(device.gpu_id, 0)
- 
+

def test_suite():
    suite = unittest.TestSuite()
Reformatting /workspace/tests/py/test_multi_gpu.py
Reformatting /workspace/tests/py/test_qat_trt_accuracy.py
Reformatting /workspace/tests/py/test_trt_intercompatability.py
Reformatting /workspace/tests/py/test_api.py
Reformatting /workspace/tests/py/test_ptq_trt_calibrator.py
Reformatting /workspace/tests/py/test_api_dla.py
Reformatting /workspace/tests/py/model_test_case.py
Reformatting /workspace/tests/py/test_to_backend_api.py
Reformatting /workspace/tests/py/test_ptq_to_backend.py
Reformatting /workspace/tests/py/test_ptq_dataloader_calibrator.py
Reformatting /workspace/tests/modules/hub.py
ERROR: Some files do not conform to style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan narendasan mentioned this pull request Sep 24, 2021
Merged
6 tasks
@narendasan narendasan merged commit ebb906f into master Sep 24, 2021
@narendasan narendasan deleted the fix_device branch September 24, 2021 18:34
@narendasan narendasan mentioned this pull request Sep 24, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@ncomly-nvidia ncomly-nvidia ncomly-nvidia approved these changes

Assignees
No one assigned
Labels
component: api [Python] Issues re: Python API component: tests Issues re: Tests release: patch This change needs to go out as a patch to the current version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narendasan @peri044 @ncomly-nvidia