Skip to content

fix(//py): Fix trtorch.Device alternate contructor options #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix(//py): Fix trtorch.Device alternate contructor options #637

merged 1 commit into from
Sep 24, 2021

Conversation

narendasan
Copy link
Collaborator

Description

Patch for v0.4.0 to fix device api in python which did not parse kwargs properly (same change as #635)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan
fix(//py): Fix trtorch.Device alternate contructor options
ac26841 
There were issues setting fields of trtorch.Device via
kwargs, this patch should resolve those and verify that they
work

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
@narendasan narendasan added the release: patch This change needs to go out as a patch to the current version label Sep 24, 2021
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: tests Issues re: Tests labels Sep 24, 2021
github-actions[bot]
github-actions bot approved these changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@narendasan narendasan merged commit 8b88d92 into master Sep 24, 2021
@narendasan narendasan deleted the patch_fix/0.4/trtorch_device branch September 24, 2021 18:34
@narendasan narendasan restored the patch_fix/0.4/trtorch_device branch September 24, 2021 18:35
@narendasan narendasan mentioned this pull request Sep 24, 2021
Closed
@narendasan narendasan deleted the patch_fix/0.4/trtorch_device branch September 24, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
component: api [Python] Issues re: Python API component: tests Issues re: Tests release: patch This change needs to go out as a patch to the current version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@narendasan