Skip to content

Support for interpolation (aten::upsample_nearest) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 8, 2020
Merged

Support for interpolation (aten::upsample_nearest) #87

merged 12 commits into from
Jun 8, 2020

Conversation

abhi-iyer
Copy link
Contributor

@abhi-iyer abhi-iyer commented Jun 6, 2020 •
edited
Loading

Description

Support for aten::upsample_nearest3d, aten::upsample_nearest2d, and aten::upsample_nearest1d

Also fixed a bug that forced input tensors to be at least 4 dimensional.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation and have regenerated the documentation (make html in docsrc)
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@narendasan narendasan requested review from narendasan and andi4191 June 6, 2020 04:06
@narendasan
Copy link
Collaborator

@abhi-iyer I think you probably should rebase this branch on master to resolve the conflicts

narendasan
narendasan requested changes Jun 6, 2020
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small needed changes so far and the rebase and tests

narendasan
narendasan requested changes Jun 6, 2020
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking the other spots for errors

abhi-iyer added 7 commits June 8, 2020 11:17
@abhi-iyer
fix(): first commit
4f1a9df 
Signed-off-by: Abhiram Iyer <[email protected]>
Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
feat(//core/conversion/converters/impl): all function schemas for ups…
1b50484 
…ample_nearest

Signed-off-by: Abhiram Iyer <[email protected]>
Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
feat(//core/conversion/converters/impl): logic implemented
7f12160 
Signed-off-by: Abhiram Iyer <[email protected]>
Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
fix(//core/conversion/converters/impl): code works for interpolate2d/…
e4cb117 
…3d, doesn't work for 1d yet

Signed-off-by: Abhiram Iyer <[email protected]>
Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
fix(//core/conversion/converters/impl): 1d case not working
f42562b 
Signed-off-by: Abhiram Iyer <[email protected]>
Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
Fix(//core/conversion/converters/impl/interpolate.cpp): Fix upsample_1d
b3b96e9 
Signed-off-by: Abhiram Iyer <[email protected]>
Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
Fix(//core/conversion/InterfaceTypes.cpp): Fix dimension padding bug,…
76e75c8 
… changed toDimsPad() to toDims()

Signed-off-by: Abhiram Iyer <[email protected]>
Signed-off-by: Abhiram Iyer <[email protected]>
narendasan
narendasan requested changes Jun 8, 2020
View reviewed changes
@abhi-iyer
delete(trace.ts): Delete it
bfe2309 
Signed-off-by: Abhiram Iyer <[email protected]>

Signed-off-by: Abhiram Iyer <[email protected]>
abhi-iyer added 3 commits June 8, 2020 12:06
@abhi-iyer
delete(test.py): delete it
9a4f6de 
Signed-off-by: Abhiram Iyer <[email protected]>

Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
fix(//core/conversion/converters/impl): Fix interpolate.cpp
b6942a2 
Signed-off-by: Abhiram Iyer <[email protected]>

Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer
Test(tests/core/converters) added 5 tests for test_interpolate
0daa237 
Signed-off-by: Abhiram Iyer <[email protected]>

Signed-off-by: Abhiram Iyer <[email protected]>
@abhi-iyer abhi-iyer changed the title Support for interpolation (aten::upsample_nearest) Support for interpolation (aten::upsample_nearest1d) Jun 8, 2020
@abhi-iyer abhi-iyer changed the title Support for interpolation (aten::upsample_nearest1d) Support for interpolation (aten::upsample_nearest) Jun 8, 2020
narendasan
narendasan requested changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we are almost there, just the errors we print should be a little more clear. Ill test out the PR and then we should be good to go.

narendasan
narendasan approved these changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending those changes to the error messages

@narendasan narendasan merged commit aa131ac into pytorch:master Jun 8, 2020
@narendasan narendasan added this to the v0.1.0 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@andi4191 andi4191 Awaiting requested review from andi4191

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@abhi-iyer @narendasan