Skip to content

feat!: Lock bazel version #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2020
Merged

feat!: Lock bazel version #99

merged 1 commit into from
Jun 13, 2020

Conversation

narendasan
Copy link
Collaborator

BREAKING CHANGE: Bazel version is now locked to Bazel 3.2.0 and will be
bumped manually from now on. Builds will fail on all other versions
since now bazel will check the version before it compiles.

Documentation on how to install bazel is added as well to support
aarch64 until bazel releases binaries for the platform (which is soon)

Signed-off-by: Naren Dasan [email protected]
Signed-off-by: Naren Dasan [email protected]

Closes #98

Type of change

Please delete options that are not relevant and/or add your own.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation and have regenerated the documentation (make html in docsrc)
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

BREAKING CHANGE: Bazel version is now locked to Bazel 3.2.0 and will be
bumped manually from now on. Builds will fail on all other versions
since now bazel will check the version before it compiles.

Documentation on how to install bazel is added as well to support
aarch64 until bazel releases binaries for the platform (which is soon)

Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]>
@narendasan narendasan assigned andi4191 and unassigned andi4191 Jun 12, 2020
@narendasan narendasan requested a review from andi4191 June 12, 2020 20:08
@narendasan narendasan merged commit 461e2ca into master Jun 13, 2020
@narendasan narendasan deleted the specify_bazel_support branch June 13, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What does it all mean Bazel?
2 participants