Use certifi certs for buck download #10095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10095
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b879186 with merge base 94f7b10 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
GregoryComer
force-pushed
the
fix-buck-download-cert-error
branch
2 times, most recently
from
7936b21 to
d82d024
Compare
GregoryComer
force-pushed
the
fix-buck-download-cert-error
branch
from
d82d024 to
0c87204
Compare
GregoryComer
added
release notes: misc
GregoryComer
force-pushed
the
fix-buck-download-cert-error
branch
from
0c87204 to
c2454fc
Compare
GregoryComer
force-pushed
the
fix-buck-download-cert-error
branch
from
c2454fc to
b879186
Compare
jathu
approved these changes
May 8, 2025
larryliu0820
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depending on how Python is installed and managed, it is common for certificates to not be installed out of box on Macs. This can cause the download of buck2 as part of the build process to fail with a certificate error.
While the ultimate solution for this is for the user to install certs in their environment, we can smooth this over a bit for build by pointing urllib at the certifi package certs, which we install as part of install_requirements.
Test plan
I worked with @nil-is-all to verify that this fix allowed him to build and install ExecuTorch from a clean environment. Without this change, he was seeing cert failure errors during buck download.