Skip to content

Use certifi certs for buck download #10095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Use certifi certs for buck download #10095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions tools/cmake/resolve_buck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import argparse
import os
import platform
import ssl
import stat
import sys
import urllib.request
Expand All @@ -18,6 +19,7 @@
from typing import Sequence, Union

import buck_util
import certifi
import zstd

"""
Expand Down Expand Up @@ -201,26 +203,23 @@ def resolve_buck2(args: argparse.Namespace) -> Union[str, int]:
if os.path.isfile(buck2_local_path):
return buck2_local_path

buck2_archive_url = f"https://github.com/facebook/buck2/releases/download/{target_buck_version}/{buck_info.archive_name}"
buck2_archive_url = f"https://github.com/facebook/buck2/releases/download/{target_buck_version}/{buck_info.archive_name}"

try:
print(f"Downloading buck2 from {buck2_archive_url}...", file=sys.stderr)
archive_file, _ = urllib.request.urlretrieve(buck2_archive_url)
print(f"Downloading buck2 from {buck2_archive_url}...", file=sys.stderr)
ssl_context = ssl.create_default_context(cafile=certifi.where())

# Extract and chmod.
with open(archive_file, "rb") as f:
data = f.read()
decompressed_bytes = zstd.decompress(data)
with urllib.request.urlopen(buck2_archive_url, context=ssl_context) as request:
# Extract and chmod.
data = request.read()
decompressed_bytes = zstd.decompress(data)

with open(buck2_local_path, "wb") as f:
f.write(decompressed_bytes)
with open(buck2_local_path, "wb") as f:
f.write(decompressed_bytes)

file_stat = os.stat(buck2_local_path)
os.chmod(buck2_local_path, file_stat.st_mode | stat.S_IEXEC)
finally:
os.remove(archive_file)
file_stat = os.stat(buck2_local_path)
os.chmod(buck2_local_path, file_stat.st_mode | stat.S_IEXEC)

return buck2_local_path
return buck2_local_path


def main():
Expand Down
Loading