Arm backend: Convert asserts to raise errors in op_mul #10134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asserts are converted to proper raises to ensure graph integrity. Improve error message. Change-Id: Ifff799651a67811e1dacdb0af5d332dcb7b4b11e Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
added
partner: arm
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10134
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9346057 with merge base bb60c25 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
digantdesai
approved these changes
Apr 16, 2025
Raise error instead of assert? I'm in the process of converting asserts to raise errors where appropriate, so in that case yes it's standard behavior. |
zingo
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts are converted to proper raises to ensure graph integrity.
Improve error message.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218