-
Notifications
You must be signed in to change notification settings - Fork 607
[cmake] Install libexecutorch.a and libportable_kernels.a #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for resplendent-gnome-14e531 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
5ff0169
to
2feb804
Compare
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1036
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit d2c3fe7 with merge base 7814dd7 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
51de4a0
to
2feb804
Compare
Summary: This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories. To install these two libraries (`libexecutorch.a` and `libportable_kernels.a`), user needs to run: ``` cmake -DBUCK2="$BUCK" \ -DCMAKE_INSTALL_PREFIX=cmake-out \ -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \ -Bcmake-out . cmake --build cmake-out -j9 --target install ``` Then in the console output we will have: ``` -- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a -- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a -- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake ``` In order to find these libraries, we can do the following in example CMakeLists.txt: ``` find_package(ExecuTorch REQUIRED) ``` Then the example CMakeLists.txt can depend on `executorch` and `portable_kernels`. Differential Revision: D50482400 Pulled By: larryliu0820
2feb804
to
a4b1a96
Compare
This pull request was exported from Phabricator. Differential Revision: D50482400 |
Summary: This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories. To install these two libraries (`libexecutorch.a` and `libportable_kernels.a`), user needs to run: ``` cmake -DBUCK2="$BUCK" \ -DCMAKE_INSTALL_PREFIX=cmake-out \ -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \ -Bcmake-out . cmake --build cmake-out -j9 --target install ``` Then in the console output we will have: ``` -- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a -- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a -- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake ``` In order to find these libraries, we can do the following in example CMakeLists.txt: ``` find_package(ExecuTorch REQUIRED) ``` Then the example CMakeLists.txt can depend on `executorch` and `portable_kernels`. Reviewed By: dbort Differential Revision: D50482400 Pulled By: larryliu0820
a4b1a96
to
d2c3fe7
Compare
This pull request was exported from Phabricator. Differential Revision: D50482400 |
@larryliu0820 merged this pull request in 6152ac4. |
Summary: Fix an issue caused by #1036 Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Fix an issue caused by #1036 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Fix an issue caused by #1036 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Fix an issue caused by #1036 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Fix an issue caused by #1036 Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories.
To install these two libraries (
libexecutorch.a
andlibportable_kernels.a
), user needs to run:Then in the console output we will have:
In order to find these libraries, we can do: