Skip to content

[cmake] Install libexecutorch.a and libportable_kernels.a #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

larryliu0820
Copy link
Contributor

This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories.

To install these two libraries (libexecutorch.a and libportable_kernels.a), user needs to run:

    cmake -DBUCK2="$BUCK" \
            -DCMAKE_INSTALL_PREFIX=cmake-out \
            -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
            -Bcmake-out .
    cmake --build cmake-out -j9 --target install 

Then in the console output we will have:

-- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake

In order to find these libraries, we can do:

find_package(ExecuTorch REQUIRED)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2023
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for resplendent-gnome-14e531 ready!

Name Link
🔨 Latest commit a4b1a96
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/653fff8761118b00084fd82c
😎 Deploy Preview https://deploy-preview-1036--resplendent-gnome-14e531.netlify.app/_modules/sdk/etrecord/_etrecord
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820 larryliu0820 force-pushed the cmake-refactor branch 2 times, most recently from 5ff0169 to 2feb804 Compare October 21, 2023 18:38
@facebook-github-bot
Copy link
Contributor

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1036

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d2c3fe7 with merge base 7814dd7 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot pushed a commit that referenced this pull request Oct 30, 2023
Summary:
This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories.

To install these two libraries (`libexecutorch.a` and `libportable_kernels.a`), user needs to run:
```
    cmake -DBUCK2="$BUCK" \
            -DCMAKE_INSTALL_PREFIX=cmake-out \
            -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
            -Bcmake-out .
    cmake --build cmake-out -j9 --target install
```
Then in the console output we will have:

```
-- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake
```
In order to find these libraries, we can do the following in example CMakeLists.txt:

```
find_package(ExecuTorch REQUIRED)
```
Then the example CMakeLists.txt can depend on `executorch` and `portable_kernels`.


Differential Revision: D50482400

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50482400

Summary:
This PR is the first one to decentralize options only used by examples, from root level CMakeLists.txt to examples directories.

To install these two libraries (`libexecutorch.a` and `libportable_kernels.a`), user needs to run:
```
    cmake -DBUCK2="$BUCK" \
            -DCMAKE_INSTALL_PREFIX=cmake-out \
            -DPYTHON_EXECUTABLE="$PYTHON_EXECUTABLE" \
            -Bcmake-out .
    cmake --build cmake-out -j9 --target install
```
Then in the console output we will have:

```
-- Installing: /home/larryliu/executorch/cmake-out/lib/libportable_kernels.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/libexecutorch.a
-- Installing: /home/larryliu/executorch/cmake-out/lib/cmake/ExecuTorch/ExecuTorchConfig.cmake
```
In order to find these libraries, we can do the following in example CMakeLists.txt:

```
find_package(ExecuTorch REQUIRED)
```
Then the example CMakeLists.txt can depend on `executorch` and `portable_kernels`.


Reviewed By: dbort

Differential Revision: D50482400

Pulled By: larryliu0820
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50482400

@facebook-github-bot
Copy link
Contributor

@larryliu0820 merged this pull request in 6152ac4.

larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
This was referenced Oct 31, 2023
larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: cf73a32
Pull Request resolved: #1114
@larryliu0820 larryliu0820 mentioned this pull request Oct 31, 2023
larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: cf73a32
Pull Request resolved: #1115
larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Oct 31, 2023
Summary: Fix an issue caused by #1036

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6c621f1
Pull Request resolved: #1115
facebook-github-bot pushed a commit that referenced this pull request Oct 31, 2023
Summary:
Pull Request resolved: #1115

Fix an issue caused by #1036

Reviewed By: cccclai

Differential Revision: D50842626

fbshipit-source-id: f7d9893193a1acb981a63149794e1fe3622b70a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants