Support named_data in flat_tensor #10527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10527
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3ab395d with merge base 4524838 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Apr 28, 2025
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/) ghstack-source-id: 280709835 Pull Request resolved: #10527
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73679683 |
This was referenced Apr 28, 2025
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Apr 28, 2025
Pull Request resolved: #10527 Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. ghstack-source-id: 280786211 Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/)
|
This pull request was exported from Phabricator. Differential Revision: D73679683 |
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73679683 |
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D73679683 |
JacobSzwejbka
approved these changes
May 1, 2025
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
May 1, 2025
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #10527 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/68/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/68/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/68/orig @diff-train-skip-merge Co-authored-by: lucylq <[email protected]>
jhelsby
pushed a commit
to jhelsby/executorch
that referenced
this pull request
May 9, 2025
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Differential Revision: [D73679683](https://our.internmc.facebook.com/intern/diff/D73679683/) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#10527 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/68/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/68/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/68/orig @diff-train-skip-merge Co-authored-by: lucylq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions.
Add support to return named_data values as well.
TODO:consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code.
Differential Revision: D73679683