Skip to content

Build Windows pybind in CI #11018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Build Windows pybind in CI #11018

merged 1 commit into from
May 27, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 20, 2025

Summary

Screenshot 2025-05-22 at 11 17 18 AM

Test plan

CI

cc @larryliu0820

Copy link

pytorch-bot bot commented May 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11018

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 62190ce with merge base 62a2509 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2025
@jathu jathu force-pushed the jathu/windows-ci branch 9 times, most recently from a50d0c7 to 7868336 Compare May 20, 2025 23:53
@jathu jathu changed the title [WIP] Build Windows pybind in CI Build Windows pybind in CI May 21, 2025
@jathu jathu force-pushed the jathu/windows-ci branch 9 times, most recently from 04f4e43 to f028b17 Compare May 21, 2025 19:52
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes labels May 21, 2025
@jathu jathu force-pushed the jathu/windows-ci branch 7 times, most recently from 8cbd667 to 2bd69ba Compare May 21, 2025 22:31
@jathu jathu force-pushed the jathu/windows-ci branch 14 times, most recently from fff6bb0 to 2145b08 Compare May 22, 2025 18:07
@jathu jathu marked this pull request as ready for review May 22, 2025 18:17
script: |
set -eux
conda init powershell
powershell -Command "& {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! So it still doesn't work via bash? If so, very curious why powershell specifically is needed...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there are some compiler errors when using bash. I think this is good for now, we can look into the bash issue later

strategy:
fail-fast: false
matrix:
preset: [pybind]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding llm now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up, just want to get this in first

@jathu jathu force-pushed the jathu/windows-ci branch from 2145b08 to 62190ce Compare May 22, 2025 19:05
@jathu jathu merged commit bd6a3ec into main May 27, 2025
92 checks passed
@jathu jathu deleted the jathu/windows-ci branch May 27, 2025 21:33
jathu added a commit that referenced this pull request May 27, 2025
jathu added a commit that referenced this pull request May 27, 2025
jathu added a commit that referenced this pull request May 27, 2025
### Summary
Accidentally deleted this line in
#11018

### Test plan
CI
jathu added a commit that referenced this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants