-
Notifications
You must be signed in to change notification settings - Fork 603
Build Windows pybind in CI #11018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Windows pybind in CI #11018
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11018
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 62190ce with merge base 62a2509 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
a50d0c7
to
7868336
Compare
04f4e43
to
f028b17
Compare
8cbd667
to
2bd69ba
Compare
fff6bb0
to
2145b08
Compare
script: | | ||
set -eux | ||
conda init powershell | ||
powershell -Command "& { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! So it still doesn't work via bash? If so, very curious why powershell specifically is needed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there are some compiler errors when using bash. I think this is good for now, we can look into the bash issue later
strategy: | ||
fail-fast: false | ||
matrix: | ||
preset: [pybind] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding llm
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow up, just want to get this in first
### Summary Accidentally deleted this line in #11018 ### Test plan CI
Summary
Test plan
CI
cc @larryliu0820