Skip to content

Reusable test framework the Inspector tests #11314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

Juntian777
Copy link
Contributor

Summary:
This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288

@Juntian777 Juntian777 requested a review from Gasoonjia as a code owner June 3, 2025 17:13
Copy link

pytorch-bot bot commented Jun 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11314

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6e0b6cb with merge base 5ef38d3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jun 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75803288

Juntian777 added a commit to Juntian777/executorch that referenced this pull request Jun 3, 2025
Summary:

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288
@Juntian777
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jun 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75803288

Juntian777 added a commit to Juntian777/executorch that referenced this pull request Jun 3, 2025
Summary:
Pull Request resolved: pytorch#11314

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288
Juntian777 added a commit to Juntian777/executorch that referenced this pull request Jun 3, 2025
Summary:

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288
Juntian777 added a commit to Juntian777/executorch that referenced this pull request Jun 3, 2025
Summary:

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288
Juntian777 added a commit to Juntian777/executorch that referenced this pull request Jun 3, 2025
Summary:

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75803288

Juntian777 added a commit to Juntian777/executorch that referenced this pull request Jun 3, 2025
Summary:
Pull Request resolved: pytorch#11314

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288
Copy link
Contributor

@Gasoonjia Gasoonjia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for continue work

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75803288

Juntian777 added a commit to Juntian777/executorch that referenced this pull request Jun 3, 2025
Summary:
Pull Request resolved: pytorch#11314

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Differential Revision: D75803288
Summary:
Pull Request resolved: pytorch#11314

This Diff introduces a reusable test framework. The inspector_test_utils.py file provides methods to instantiate the model, retrieve expected outputs, and assert the correctness of actual outputs in a extensible way.

Also, update the intermediate_output_capturer_test to take advantage of the reusable framework and make the intermediate_output_capturer_test more extensible by using reusable setup method, making it easier to add new models and tests.

Reviewed By: Gasoonjia

Differential Revision: D75803288
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75803288

@facebook-github-bot facebook-github-bot merged commit dfa5dbc into pytorch:main Jun 4, 2025
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants