Skip to content

fix-up #11362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix-up #11362

merged 1 commit into from
Jun 4, 2025

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jun 4, 2025

Summary: See if this resolves the errors, otherwise revert D75923129.

Reviewed By: swolchok

Differential Revision: D75966982

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11362

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c7fe0d6 with merge base 93b1a0c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75966982

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok swolchok mentioned this pull request Jun 4, 2025
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75966982

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Jun 4, 2025
@lucylq @facebook-github-bot
fix-up (pytorch#11362)
31f6915 
Summary:
Pull Request resolved: pytorch#11362

See if this resolves the errors, otherwise revert D75923129.

Reviewed By: swolchok

Differential Revision: D75966982
@lucylq lucylq force-pushed the export-D75966982 branch from 201751a to 31f6915 Compare June 4, 2025 18:09
@lucylq @facebook-github-bot
fix-up (pytorch#11362)
c7fe0d6 
Summary:
Pull Request resolved: pytorch#11362

See if this resolves the errors, otherwise revert D75923129.

Reviewed By: swolchok

Differential Revision: D75966982
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75966982

@lucylq lucylq force-pushed the export-D75966982 branch from 31f6915 to c7fe0d6 Compare June 4, 2025 18:23
@facebook-github-bot facebook-github-bot merged commit e4b91fa into pytorch:main Jun 4, 2025
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok swolchok approved these changes

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucylq @facebook-github-bot @swolchok