Skip to content

Fix -Wformat issues from #8612 #11360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix -Wformat issues from #8612 #11360

wants to merge 1 commit into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 4, 2025

Built locally with -Wformat -Werror=format on a recent version of clang. (Apparently, clang12 which we use on CI is not new enough?)

@swolchok
Update
b1efb60 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jun 4, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11360

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 13 Pending

As of commit b1efb60 with merge base a2b22fd (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jun 4, 2025
@swolchok
Fix -Wformat issues from #8612
6bfad8b 
Built locally with -Wformat -Werror=format on a recent version of clang. (Apparently, clang12 which we use on CI is not new enough?)


ghstack-source-id: d676877
ghstack-comment-id: 2940815253
Pull-Request-resolved: #11360
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jun 4, 2025
@swolchok
Copy link
Contributor Author

swolchok commented Jun 4, 2025

lucy sent this as #11362

@swolchok swolchok closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swolchok @facebook-github-bot