Arm backend: Bump cortex-m size test threshold #11520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size to runtime has grown and this started to fail. Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I03f76b1c2ef6c47876af150db42bb42949c1dffa
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11520
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5dcba60 with merge base 954f0e9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
module: arm
Merged
|
#11499 seem to have bumped the bin size slightly for the cortex-m build, tjis bumps the test threshold (assuming the bigger size was ok) |
mergennachin
approved these changes
Jun 10, 2025
digantdesai
approved these changes
Jun 10, 2025
|
Good idea There are some code added in #11499 when we started to fail, Ill add a pointer to the commit msg for future tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size to runtime has grown and this started to fail after some code was improved/added in the "Refactor FlatTensor" change: #11499 and we got ~50 Bytes over the limit.
cc @digantdesai @freddan80 @per @oscarandersson8218