Refactor FlatTensor #11499
Merged
Refactor FlatTensor #11499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucylq
requested review from
JacobSzwejbka,
swolchok and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11499
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2a3ac1f with merge base a7a9130 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76285590 |
lucylq
added
the
release notes: api
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 9, 2025
Summary: This diff is the stack at D73209986 combined. Landing as one diff/PR as it contains BC-breaking changes throughout the stack. Differential Revision: D76285590
|
This pull request was exported from Phabricator. Differential Revision: D76285590 |
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 9, 2025
Summary: Pull Request resolved: pytorch#11499 This diff is the stack at D73209986 combined. Landing as one diff/PR as it contains BC-breaking changes throughout the stack. Differential Revision: D76285590
lucylq
added a commit
to lucylq/executorch-1
that referenced
this pull request
Jun 9, 2025
Summary: This diff is the stack at D73209986 combined. Landing as one diff/PR as it contains BC-breaking changes throughout the stack. Differential Revision: D76285590
|
This pull request was exported from Phabricator. Differential Revision: D76285590 |
JacobSzwejbka
approved these changes
Jun 9, 2025
Summary: This diff is the stack at D73209986 combined. Landing as one diff/PR as it contains BC-breaking changes throughout the stack. Reviewed By: JacobSzwejbka Differential Revision: D76285590
|
This pull request was exported from Phabricator. Differential Revision: D76285590 |
|
This seem to have pushed trunk / test-arm-cortex-m-size-test / linux-job about 50 bytes over the limit. |
|
Possible fix #11520 |
zingo
added a commit
that referenced
this pull request
Jun 10, 2025
Size to runtime has grown and this started to fail after some code was improved/added in the "Refactor FlatTensor" change: #11499 and we got ~50 Bytes over the limit. Signed-off-by: Zingo Andersen <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is the stack at D73209986 combined.
Landing as one diff/PR as it contains BC-breaking changes throughout the stack.
Differential Revision: D76285590