Unbreak build_size_test.sh on Mac #12089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12089
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 7 Pending, 1 Unrelated FailureAs of commit 665c8f0 with merge base cf0bfd2 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Jun 28, 2025
By accidentally fixing the code in test/build_size_test.sh to correctly detect release builds (EQUAL is for numbers; you need STREQUAL for strings), #12045 broke that script on Mac because `--gc-sections` is not a valid linker flag there. This PR creates a general utility function for stripping dead code in linker flags and uses it everywhere we currently set `--gc-sections`. ghstack-source-id: 58a2fd2 ghstack-comment-id: 3014707984 Pull-Request-resolved: #12089
facebook-github-bot
added
the
CLA Signed
larryliu0820
approved these changes
Jun 28, 2025
mergennachin
force-pushed
the
gh/swolchok/484/head
branch
from
a3f0bf7 to
665c8f0
Compare
|
For low level build stuff, let's add |
mergennachin
added a commit
that referenced
this pull request
Jun 28, 2025
Fix llava test target cmake #12089 had a typo
I didn't realize this failure showed up on CI somewhere; I noticed because I was running the script locally. I thought that we only ran size tests on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accidentally fixing the code in test/build_size_test.sh to correctly detect release builds (EQUAL is for numbers; you need STREQUAL for strings), #12045 broke that script on Mac because
--gc-sectionsis not a valid linker flag there. This PR creates a general utility function for stripping dead code in linker flags and uses it everywhere we currently set--gc-sections.