Introduce write_to_file api #2307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2307
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 09ea15e with merge base 9d6bf72 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54526788 |
Summary: And update existing callsites to use bytes(serialize_pte_binary..), or write_to_file Differential Revision: D54524444
Summary: Pull Request resolved: pytorch#2307 Update callsites that save to file to use write_to_file api instead of .buffer Reviewed By: dbort Differential Revision: D54526788
|
This pull request was exported from Phabricator. Differential Revision: D54526788 |
|
@pytorchbot label ciflow/trunk |
|
This pull request has been merged in 5316e69. |
robell
added a commit
to robell/executorch
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Rob Elliott <[email protected]> Change-Id: I584410307d4b9c2635ae6647cd9bd138bf596c45
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
Summary: Fixes for a few things: - Move C++ std to 17 to enable changes for #1733 on Arm builds - fix after #2307 regressed save_pte_program on aot_arm_compiler - add aot_arm_compiler support for examples/models (they don't all compile but can be consumed) - Move the Vela pin in anticipation of MNV2 tosa fixes in #2371 Pull Request resolved: #2372 Reviewed By: mcr229 Differential Revision: D54817009 Pulled By: digantdesai fbshipit-source-id: 5ca3c7a03e8ae9f6a784335d53654b8db05a3cb8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update callsites that save to file to use write_to_file api instead of .buffer
Reviewed By: dbort
Differential Revision: D54526788