[ET-VK][EZ] Fix comment style for parameter names #2847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIL from the linter and @SSJia's code that this is bad style ``` get_val_or_inf(graph, args[1], /*max =*/false), ``` and this is good style: ``` get_val_or_inf(graph, args[1], /*max = */ false), ``` Differential Revision: [D55721203](https://our.internmc.facebook.com/intern/diff/D55721203/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2847
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit fc1ac45 with merge base d3326a2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Apr 4, 2024
|
This pull request was exported from Phabricator. Differential Revision: D55721203 |
This was referenced Apr 5, 2024
Closed
TIL from the linter and ssjia's code that this is bad style ``` get_val_or_inf(graph, args[1], /*max =*/false), ``` and this is good style: ``` get_val_or_inf(graph, args[1], /*max = */ false), ``` Differential Revision: [D55721203](https://our.internmc.facebook.com/intern/diff/D55721203/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D55721203 |
|
This pull request has been merged in b51be72. |
Closed
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#2847 TIL from the linter and @SSJia's code that this is bad style ``` get_val_or_inf(graph, args[1], /*max =*/false), ``` and this is good style: ``` get_val_or_inf(graph, args[1], /*max = */ false), ``` ghstack-source-id: 221721757 @exported-using-ghexport Differential Revision: [D55721203](https://our.internmc.facebook.com/intern/diff/D55721203/)
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
TIL from the linter and ssjia's code that this is bad style ``` get_val_or_inf(graph, args[1], /*max =*/false), ``` and this is good style: ``` get_val_or_inf(graph, args[1], /*max = */ false), ``` Differential Revision: [D55721203](https://our.internmc.facebook.com/intern/diff/D55721203/) ghstack-source-id: 221216590 Pull Request resolved: pytorch/executorch#2847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
TIL from the linter and @SSJia's code that this is bad style
and this is good style:
Differential Revision: D55721203