Skip to content

Forward fix macOS jobs after test-infra #5086 #2980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/_unittest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ jobs:
script: |
set -eux

WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"

BUILD_TOOL=${{ matrix.build-tool }}

bash .ci/scripts/setup-conda.sh
Expand All @@ -75,5 +72,3 @@ jobs:
${CONDA_RUN} pytest -n auto --cov=./ --cov-report=xml
# Run gtest
${CONDA_RUN} buck2 test runtime/core/... runtime/platform/...

popd
8 changes: 0 additions & 8 deletions .github/workflows/apple.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ jobs:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: 90
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"
BUILD_TOOL=cmake

.ci/scripts/setup-conda.sh
Expand All @@ -48,8 +46,6 @@ jobs:
PYTHON_EXECUTABLE=python ${CONDA_RUN} --no-capture-output \
build/test_ios_ci.sh

popd

build-frameworks-ios:
name: build-frameworks-ios
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
Expand All @@ -61,8 +57,6 @@ jobs:
upload-artifact: executorch-frameworks-ios
timeout: 90
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"
BUILD_TOOL=cmake
VERSION="0.1.0"
FRAMEWORKS=(
Expand Down Expand Up @@ -111,8 +105,6 @@ jobs:
zip -r "${RUNNER_TEMP}/artifacts/${FRAMEWORK}_debug-${VERSION}.zip" "${FRAMEWORK}_debug.xcframework"
) done

popd

upload-frameworks-ios:
runs-on: ubuntu-22.04
needs: build-frameworks-ios
Expand Down
22 changes: 0 additions & 22 deletions .github/workflows/trunk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ jobs:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: ${{ matrix.timeout }}
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"

MODEL_NAME=${{ matrix.model }}
BUILD_TOOL=${{ matrix.build-tool }}
BACKEND=${{ matrix.backend }}
Expand All @@ -59,7 +56,6 @@ jobs:
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
# Build and test xecutorch
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/test.sh "${MODEL_NAME}" "${BUILD_TOOL}" "${BACKEND}" "${DEMO_BACKEND_DELEGATION}"
popd

test-custom-ops-macos:
name: test-custom-ops-macos
Expand All @@ -75,17 +71,13 @@ jobs:
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"

BUILD_TOOL=${{ matrix.build-tool }}

bash .ci/scripts/setup-conda.sh
# Setup MacOS dependencies as there is no Docker support on MacOS atm
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
# Build and test custom ops
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash examples/portable/custom_ops/test_custom_ops.sh "${BUILD_TOOL}"
popd

test-selective-build-macos:
name: test-selective-build-macos
Expand All @@ -101,17 +93,13 @@ jobs:
submodules: 'true'
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"

BUILD_TOOL=${{ matrix.build-tool }}

bash .ci/scripts/setup-conda.sh
# Setup MacOS dependencies as there is no Docker support on MacOS atm
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
# Build and test selective build
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash examples/selective_build/test_selective_build.sh "${BUILD_TOOL}"
popd

test-demo-backend-delegation:
name: test-demo-backend-delegation
Expand Down Expand Up @@ -208,17 +196,13 @@ jobs:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: 90
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"

BUILD_TOOL=cmake

bash .ci/scripts/setup-conda.sh
# Setup MacOS dependencies as there is no Docker support on MacOS atm
GITHUB_RUNNER=1 PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
# Build and test coreml delegate
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash backends/apple/coreml/scripts/build_all.sh
popd

test-pybind-build-macos:
name: test-pybind-build-macos
Expand All @@ -235,8 +219,6 @@ jobs:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: 180
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"
bash .ci/scripts/setup-conda.sh

# build module for executorch.extension.pybindings.portable_lib
Expand All @@ -245,7 +227,6 @@ jobs:

# see if we can import the module successfully
${CONDA_RUN} python -c "from executorch.extension.pybindings import portable_lib; print('success!')"
popd

test-llama-runner-macos:
name: test-llama-runner-mac
Expand All @@ -263,8 +244,6 @@ jobs:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout: 900
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"
bash .ci/scripts/setup-conda.sh

DTYPE=${{ matrix.dtype }}
Expand All @@ -278,4 +257,3 @@ jobs:
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash examples/models/llama2/install_requirements.sh
# Test llama2
PYTHON_EXECUTABLE=python ${CONDA_RUN} bash .ci/scripts/test_llama.sh stories110M.pt "${BUILD_TOOL}" "${DTYPE}" "${MODE}"
popd