[executorch] Make HierarchicalAllocator use buffers instead of MemoryAllocators #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Allocators The only operations that HierarchicalAllocator performs on its MemoryAllocator entries are `base_address()` and `size()`, which means that they're not really allocators, they're just buffers. Move to using an array of simple "pointer and size" elements (represented by Spans). This will ultimately let us remove `base_address()` and `size()` from `MemoryAllocator`, which are incompatible with dynamic subclasses like `MallocMemoryAllocator`. To help demonstrate that the new version works, make `ManagedMemoryManager` use spans. This will cause a few dozen tests around the tree to start using spans as well. Differential Revision: [D49344931](https://our.internmc.facebook.com/intern/diff/D49344931/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Sep 17, 2023
…d of MemoryAllocators" The only operations that HierarchicalAllocator performs on its MemoryAllocator entries are `base_address()` and `size()`, which means that they're not really allocators, they're just buffers. Move to using an array of simple "pointer and size" elements (represented by Spans). This will ultimately let us remove `base_address()` and `size()` from `MemoryAllocator`, which are incompatible with dynamic subclasses like `MallocMemoryAllocator`. To help demonstrate that the new version works, make `ManagedMemoryManager` use spans. This will cause a few dozen tests around the tree to start using spans as well. Differential Revision: [D49344931](https://our.internmc.facebook.com/intern/diff/D49344931/) [ghstack-poisoned]
…d of MemoryAllocators" The only operations that HierarchicalAllocator performs on its MemoryAllocator entries are `base_address()` and `size()`, which means that they're not really allocators, they're just buffers. Move to using an array of simple "pointer and size" elements (represented by Spans). This will ultimately let us remove `base_address()` and `size()` from `MemoryAllocator`, which are incompatible with dynamic subclasses like `MallocMemoryAllocator`. To help demonstrate that the new version works, make `ManagedMemoryManager` use spans. This will cause a few dozen tests around the tree to start using spans as well. Differential Revision: [D49344931](https://our.internmc.facebook.com/intern/diff/D49344931/) [ghstack-poisoned]
…d of MemoryAllocators" The only operations that HierarchicalAllocator performs on its MemoryAllocator entries are `base_address()` and `size()`, which means that they're not really allocators, they're just buffers. Move to using an array of simple "pointer and size" elements (represented by Spans). This will ultimately let us remove `base_address()` and `size()` from `MemoryAllocator`, which are incompatible with dynamic subclasses like `MallocMemoryAllocator`. To help demonstrate that the new version works, make `ManagedMemoryManager` use spans. This will cause a few dozen tests around the tree to start using spans as well. Differential Revision: [D49344931](https://our.internmc.facebook.com/intern/diff/D49344931/) [ghstack-poisoned]
This was referenced Sep 19, 2023
|
This pull request has been merged in 58c8c92. |
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The only operations that HierarchicalAllocator performs on its MemoryAllocator entries are
base_address()andsize(), which means that they're not really allocators, they're just buffers.Move to using an array of simple "pointer and size" elements (represented by Spans).
This will ultimately let us remove
base_address()andsize()fromMemoryAllocator, which are incompatible with dynamic subclasses likeMallocMemoryAllocator.To help demonstrate that the new version works, make
ManagedMemoryManageruse spans. This will cause a few dozen tests around the tree to start using spans as well.Differential Revision: D49344931