Skip to content

Add PR/issue workflow to CONTRIBUTING.md #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add PR/issue workflow to CONTRIBUTING.md #4107

wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Jul 1, 2024

Give contributors more instructions for how we would like them to claim issues and work on PRs.

Based on https://github.com/pytorch/torchtune/blob/main/CONTRIBUTING.md

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4107

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit b484697 with merge base 998fc08 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2024
@dbort dbort requested review from mergennachin, byjlw and guangy10 July 1, 2024 23:10
@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mergennachin
mergennachin reviewed Jul 2, 2024
View reviewed changes
mergennachin
mergennachin approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, see inline comment.

@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@dbort dbort force-pushed the contributing branch 2 times, most recently from 726266e to cc6558b Compare July 2, 2024 17:49
@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@dbort
Add PR/issue workflow to CONTRIBUTING.md
b484697 
Give contributors more instructions for how we would like them to claim
issues and work on PRs.

Based on https://github.com/pytorch/torchtune/blob/main/CONTRIBUTING.md
@facebook-github-bot
Copy link
Contributor

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@dbort merged this pull request in 516f7f0.

@dbort dbort deleted the contributing branch July 3, 2024 22:33
dbort added a commit to dbort/executorch that referenced this pull request Jul 3, 2024
@dbort
Add PR/issue workflow to CONTRIBUTING.md (pytorch#4107)
50c2a99 
Summary:
Give contributors more instructions for how we would like them to claim issues and work on PRs.

Based on https://github.com/pytorch/torchtune/blob/main/CONTRIBUTING.md

Pull Request resolved: pytorch#4107

Reviewed By: mergennachin

Differential Revision: D59251166

Pulled By: dbort

fbshipit-source-id: 29f696452708552feec109eb15dbaae987507258
@dbort dbort mentioned this pull request Jul 3, 2024
Closed
lucylq pushed a commit that referenced this pull request Jul 5, 2024
@dbort
Add PR/issue workflow to CONTRIBUTING.md (#4107) (#4153)
211590e 
Summary:
Give contributors more instructions for how we would like them to claim issues and work on PRs.

Based on https://github.com/pytorch/torchtune/blob/main/CONTRIBUTING.md

Pull Request resolved: #4107

Reviewed By: mergennachin

Differential Revision: D59251166

Pulled By: dbort

fbshipit-source-id: 29f696452708552feec109eb15dbaae987507258
kirklandsign pushed a commit to kirklandsign/executorch that referenced this pull request Jul 5, 2024
@dbort @kirklandsign
Add PR/issue workflow to CONTRIBUTING.md (pytorch#4107)
8223b1c 
Summary:
Give contributors more instructions for how we would like them to claim issues and work on PRs.

Based on https://github.com/pytorch/torchtune/blob/main/CONTRIBUTING.md

Pull Request resolved: pytorch#4107

Reviewed By: mergennachin

Differential Revision: D59251166

Pulled By: dbort

fbshipit-source-id: 29f696452708552feec109eb15dbaae987507258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@byjlw byjlw Awaiting requested review from byjlw

@guangy10 guangy10 Awaiting requested review from guangy10

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbort @facebook-github-bot @mergennachin