Skip to content

[ET-VK] Create containers/ folder in api/ #4181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[ET-VK] Create containers/ folder in api/ #4181

wants to merge 2 commits into from

Conversation

jorgep31415
Copy link
Contributor

@jorgep31415 jorgep31415 commented Jul 9, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

find . -type f -exec sed -i 's/api\/Tensor/api\/containers\/Tensor/g' {} +
find . -type f -exec sed -i 's/api\/ParamsBuffer/api\/containers\/ParamsBuffer/g' {} +
find . -type f -exec sed -i 's/api\/StorageBuffer/api\/containers\/StorageBuffer/g' {} +

Differential Revision: D59527912

@jorgep31415
[ET-VK] Create containers/ folder in api/
efeabf8 
```
find . -type f -exec sed -i 's/api\/Tensor/api\/containers\/Tensor/g' {} +
find . -type f -exec sed -i 's/api\/ParamsBuffer/api\/containers\/ParamsBuffer/g' {} +
find . -type f -exec sed -i 's/api\/StorageBuffer/api\/containers\/StorageBuffer/g' {} +
```

Differential Revision: [D59527912](https://our.internmc.facebook.com/intern/diff/D59527912/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4181

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f2cb94f with merge base bdbfcc6 (image):

NEW FAILURE - The following job has failed:

  • pull / unittest / linux / linux-job (gh)
    undefined reference to vkcompute::vkapi::BufferMemoryBarrier::BufferMemoryBarrier(unsigned int, unsigned int, vkcompute::vkapi::VulkanBuffer const&)'`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2024
@jorgep31415 jorgep31415 mentioned this pull request Jul 9, 2024
Closed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59527912

@jorgep31415 jorgep31415 mentioned this pull request Jul 9, 2024
Closed
This was referenced Jul 9, 2024
Closed
Closed
@jorgep31415
Update on "[ET-VK] Create containers/ folder in api/"
f2cb94f 
```
find . -type f -exec sed -i 's/api\/Tensor/api\/containers\/Tensor/g' {} +
find . -type f -exec sed -i 's/api\/ParamsBuffer/api\/containers\/ParamsBuffer/g' {} +
find . -type f -exec sed -i 's/api\/StorageBuffer/api\/containers\/StorageBuffer/g' {} +
```

Differential Revision: [D59527912](https://our.internmc.facebook.com/intern/diff/D59527912/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59527912

This was referenced Jul 9, 2024
Closed
Closed
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d93176a.

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
@jorgep31415
[ET-VK] Create containers/ folder in api/
293e49b 
Pull Request resolved: pytorch/executorch#4181

```
find . -type f -exec sed -i 's/api\/Tensor/api\/containers\/Tensor/g' {} +
find . -type f -exec sed -i 's/api\/ParamsBuffer/api\/containers\/ParamsBuffer/g' {} +
find . -type f -exec sed -i 's/api\/StorageBuffer/api\/containers\/StorageBuffer/g' {} +
```
ghstack-source-id: 233085712
@exported-using-ghexport

Differential Revision: [D59527912](https://our.internmc.facebook.com/intern/diff/D59527912/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgep31415 @facebook-github-bot @SS-JIA