Skip to content

Add the example non-genai qnn model to ci and benchinfra #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add the example non-genai qnn model to ci and benchinfra #4747

merged 1 commit into from
Aug 20, 2024

Conversation

guangy10
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 2 Unrelated Failures

As of commit e59c8dc with merge base 2b3c01c (image):

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2024
@guangy10 guangy10 force-pushed the qnn_model_in_ci branch 6 times, most recently from 93fa61f to 0c5465a Compare August 16, 2024 02:47
@guangy10
Copy link
Contributor Author

Fix EXECUTORCH_ROOT env

@guangy10 guangy10 force-pushed the qnn_model_in_ci branch 5 times, most recently from 74f37b0 to d25a8ad Compare August 16, 2024 06:15
@guangy10 guangy10 marked this pull request as ready for review August 16, 2024 21:22
@guangy10 guangy10 force-pushed the qnn_model_in_ci branch 5 times, most recently from 1ba4227 to da54a2f Compare August 16, 2024 22:06
@guangy10
Copy link
Contributor Author

@haowhsu-quic The script to export dl3 doesn't work. Same failure when I run the export script locally from latest main. See the job https://github.com/pytorch/executorch/actions/runs/10426838811/job/28880603010?pr=4747

cccclai
cccclai reviewed Aug 17, 2024
View reviewed changes
cccclai
cccclai reviewed Aug 17, 2024
View reviewed changes
@haowhsu-quic
Copy link
Collaborator

@haowhsu-quic The script to export dl3 doesn't work. Same failure when I run the export script locally from latest main. See the job https://github.com/pytorch/executorch/actions/runs/10426838811/job/28880603010?pr=4747

Hi, I think this was a breakage introduced by recent PR #4566.
Would it be possible to have #4774 for resolving issue?

@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor Author

Rebased after #4774 got merged

@guangy10
Copy link
Contributor Author

test-qnn-model job passes

@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the qnn_model_in_ci branch 2 times, most recently from e7be2ae to d1a970b Compare August 19, 2024 22:46
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10 guangy10 force-pushed the qnn_model_in_ci branch 2 times, most recently from c8424b0 to b1f488b Compare August 19, 2024 23:48
@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangy10
Copy link
Contributor Author

Now we can see the qnn and xnnpack models are exported, uploaded and deployed to S22 via device farm successfully: https://github.com/pytorch/executorch/actions/runs/10463149566. Once we have 1) the generic apk loader and 2) bundled models we should be able to benchmark these models ondevice

Only dl3 is added to the CI and benchinfra, other models are missing instructions to use. See #4767.

@facebook-github-bot
Copy link
Contributor

@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 482f60f into main Aug 20, 2024
62 of 66 checks passed
@guangy10 guangy10 deleted the qnn_model_in_ci branch August 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccclai cccclai cccclai left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

@metascroy metascroy metascroy approved these changes

@haowhsu-quic haowhsu-quic Awaiting requested review from haowhsu-quic

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guangy10 @haowhsu-quic @facebook-github-bot @cccclai @kirklandsign @metascroy