Forward fix test_create_submodule_list_return to be backwards compatible #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: From `TODO` comment: `split.Tensor` now gets decomposed to split_with_sizes. Due to how executorch uses a pinned Pytorch nightly, the CI may not catch the changes to Pytorch's core decomposition table. As a temporary workaround, make the test backwards compatible with the old decomposition table. Remove the or statement once Pytorch nightly has been updated. Reviewed By: dbort Differential Revision: D49878902 Privacy Context Container: L1124100
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49878902 |
|
This pull request has been merged in 141fcf6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
From
TODOcomment:split.Tensornow gets decomposed to split_with_sizes. Due to how executorch uses a pinned Pytorch nightly, the CI may not catch the changes to Pytorch's core decomposition table. As a temporary workaround, make the test backwards compatible with the old decomposition table. Remove the or statement once Pytorch nightly has been updated.Reviewed By: dbort
Differential Revision:
D49878902
Privacy Context Container: L1124100