[8/n][ET-VK] Support staging any bitw8 image, take 2 #6028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`starts_with` is a C++20 feature but OSS is on C++17. https://en.cppreference.com/w/cpp/string/basic_string/starts_with Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6028
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 754fc0e with merge base e540bcb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jorgep31415
added a commit
that referenced
this pull request
Oct 8, 2024
`starts_with` is a C++20 feature but OSS is on C++17. https://en.cppreference.com/w/cpp/string/basic_string/starts_with Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/) ghstack-source-id: 246947068 Pull Request resolved: #6028
|
This pull request was exported from Phabricator. Differential Revision: D64076249 |
`starts_with` is a C++20 feature but OSS is on C++17. https://en.cppreference.com/w/cpp/string/basic_string/starts_with Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/) [ghstack-poisoned]
jorgep31415
added a commit
that referenced
this pull request
Oct 8, 2024
Pull Request resolved: #6028 `starts_with` is a C++20 feature but OSS is on C++17. https://en.cppreference.com/w/cpp/string/basic_string/starts_with Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/) ghstack-source-id: 246948295
|
This pull request was exported from Phabricator. Differential Revision: D64076249 |
jorgep31415
changed the title
starts_with usage
This was referenced Oct 9, 2024
"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit. Changes follow from #4485 to support texture2d and support uint8, respectively. Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64076249 |
SS-JIA
approved these changes
Oct 9, 2024
"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit. Changes follow from #4485 to support texture2d and support uint8, respectively. Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64076249 |
|
This pull request has been merged in d3cd09c. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#6028 "bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit. Changes follow from pytorch/executorch#4485 to support `texture2d` and support `uint8`, respectively. (Redo of pytorch/executorch#5934) ghstack-source-id: 247078906 Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
VkUtils.hinapi.h#6066create_image_from_ahbutility #5992"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.
Changes follow from #4485 to support texture2d and support uint8, respectively.
Differential Revision: D64076249