[8/n][ET-VK] Support staging any 8-bit texture #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jorgep31415 wants to merge 7 commits into gh/jorgep31415/118/base from gh/jorgep31415/118/head

Contributor

jorgep31415 commented Oct 7, 2024 •

edited

Loading

Stack from ghstack (oldest at bottom):

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support texture2d and support uint8, respectively.

Differential Revision: D63918659


          [8/n][ET-VK] Support staging any 8-bit texture

88ab798

Changes following from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

[ghstack-poisoned]

pytorch-bot bot commented Oct 7, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5934

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2785b4e with merge base cb12061 ():

NEW FAILURE - The following job has failed:

pull / unittest / linux / linux-job (gh)
/pytorch/executorch/backends/vulkan/runtime/graph/ops/impl/Staging.cpp:83:26: error: no member named 'starts_with' in 'std::basic_string<char>'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

This was referenced Oct 7, 2024

[5/n][ET-VK] Enable uint8 dtype in shaders #5932

Closed

[5/n][ET-VK][Ops] aten.flip #5879

Closed

[7/n][ET-VK] Support texture2D in etvk.copy_offset #5933

Closed

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63918659

facebook-github-bot added the fb-exported label

jorgep31415 added a commit that referenced this pull request


          [8/n][ET-VK] Support staging any 8-bit texture

41fba77

Changes following from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

ghstack-source-id: 246607065
Pull Request resolved: #5934


          Update on "[8/n][ET-VK] Support staging any 8-bit texture"

7c182ea

Changes following from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63918659

jorgep31415 added a commit that referenced this pull request


          [8/n][ET-VK] Support staging any 8-bit texture

952f3cd

Pull Request resolved: #5934

Changes following from #4485 to support `texture2d` and support `uint8`, respectively.
ghstack-source-id: 246658454
@exported-using-ghexport

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

SS-JIA approved these changes

View reviewed changes


          Update on "[8/n][ET-VK] Support staging any 8-bit texture"

53ce2f1

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63918659

jorgep31415 added a commit that referenced this pull request


          [8/n][ET-VK] Support staging any bitw8 image

915ba46

Pull Request resolved: #5934

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.
ghstack-source-id: 246672275
@exported-using-ghexport

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)


          Update on "[8/n][ET-VK] Support staging any 8-bit texture"

16e5fbe

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

[ghstack-poisoned]

jorgep31415 added a commit that referenced this pull request


          [8/n][ET-VK] Support staging any bitw8 image

b1ac789

Pull Request resolved: #5934

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.
ghstack-source-id: 246725187
@exported-using-ghexport

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

Contributor

facebook-github-bot commented Oct 7, 2024

This pull request was exported from Phabricator. Differential Revision: D63918659


          Update on "[8/n][ET-VK] Support staging any 8-bit texture"

458b373

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63918659

jorgep31415 added a commit that referenced this pull request


          [8/n][ET-VK] Support staging any bitw8 image

d851f88

Pull Request resolved: #5934

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.
ghstack-source-id: 246850704
@exported-using-ghexport

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)


          Update on "[8/n][ET-VK] Support staging any 8-bit texture"

f0315db

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63918659

jorgep31415 added a commit that referenced this pull request


          [8/n][ET-VK] Support staging any bitw8 image

03d6cf2

Pull Request resolved: #5934

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.
ghstack-source-id: 246869292
@exported-using-ghexport

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)


          Update on "[8/n][ET-VK] Support staging any 8-bit texture"

2785b4e

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

[ghstack-poisoned]

jorgep31415 added a commit that referenced this pull request


          [8/n][ET-VK] Support staging any bitw8 image

b66c255

Pull Request resolved: #5934

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.
ghstack-source-id: 246872869
@exported-using-ghexport

Differential Revision: [D63918659](https://our.internmc.facebook.com/intern/diff/D63918659/)

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request was exported from Phabricator. Differential Revision: D63918659

This was referenced Oct 8, 2024

[10/n][ET-VK] Introduce create_image_from_ahb utility #5992

Closed

[11/n][ET-VK] Introduce vTensor creation from external image #5993

Closed

jorgep31415 mentioned this pull request

[13/n][ET-VK] Introduce rgba <-> image conversion shaders #5994

Closed

facebook-github-bot closed this in

f8cec53

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Oct 8, 2024

This pull request has been merged in f8cec53.

Contributor

dbort commented Oct 8, 2024

Reverting this with #6027 because it broke the unittest / linux / linux-job build:

https://github.com/pytorch/executorch/actions/runs/11242482373/job/31256276319

/pytorch/executorch/backends/vulkan/runtime/graph/ops/impl/Staging.cpp:83:26: error: no member named 'starts_with' in 'std::basic_string<char>'
  if (shader.kernel_name.starts_with("bitw8_image_to_nchw_nobitw8buffer")) {
      ~~~~~~~~~~~~~~~~~~ ^
1 error generated.
gmake[2]: *** [backends/vulkan/CMakeFiles/vulkan_backend.dir/build.make:636: backends/vulkan/CMakeFiles/vulkan_backend.dir/runtime/graph/ops/impl/Staging.cpp.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....

jorgep31415 mentioned this pull request

[8/n][ET-VK] Support staging any bitw8 image, take 2 #6028

Closed

Contributor

facebook-github-bot commented Oct 9, 2024

This pull request has been reverted by b6e6d06.

facebook-github-bot added the Reverted label

facebook-github-bot pushed a commit that referenced this pull request


          Support staging any bitw8 image, take 2 (#6028)

d3cd09c

Summary:
Pull Request resolved: #6028

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from #4485 to support `texture2d` and support `uint8`, respectively.

(Redo of #5934)
ghstack-source-id: 247078906

Reviewed By: SS-JIA

Differential Revision: D64076249

fbshipit-source-id: 541cfddf92c55ebd4c6e39c6bd041fb5aa78b3b9

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          [8/n][ET-VK] Support staging any bitw8 image, take 2

e08d3e1

Pull Request resolved: pytorch/executorch#6028

"bitw8" = bit width 8, which is equivalent to 8-bit. We use "bitw8" as the name since shader compilation disallows names starting with a digit.

Changes follow from pytorch/executorch#4485 to support `texture2d` and support `uint8`, respectively.

(Redo of pytorch/executorch#5934)
ghstack-source-id: 247078906

Differential Revision: [D64076249](https://our.internmc.facebook.com/intern/diff/D64076249/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged Reverted