Skip to content

[executorch][cmake] Add EXECUTORCH_ENABLE_LOGGING and EXECUTORCH_ENABLE_PROGRAM_VERIFICATION #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dbort
Copy link
Contributor

@dbort dbort commented Oct 4, 2023

Stack from ghstack (oldest at bottom):

These flags should be off by default in Release mode, but some users may want to enable them.

This sets a convention for future options like this, which should also use ${_default_release_disabled_targets}.

Differential Revision: D49925195

…LE_PROGRAM_VERIFICATION

These flags should be off by default in Release mode, but some users may want to enable them.

This sets a convention for future options like this, which should also use `${_default_release_disabled_targets}`.

Differential Revision: [D49925195](https://our.internmc.facebook.com/intern/diff/D49925195/)

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2023
dbort added a commit that referenced this pull request Oct 4, 2023
…LE_PROGRAM_VERIFICATION

These flags should be off by default in Release mode, but some users may want to enable them.

This sets a convention for future options like this, which should also use `${_default_release_disabled_targets}`.

Differential Revision: [D49925195](https://our.internmc.facebook.com/intern/diff/D49925195/)

ghstack-source-id: 202924824
Pull Request resolved: #617
@dbort dbort closed this Oct 5, 2023
facebook-github-bot pushed a commit that referenced this pull request Oct 5, 2023
…ION (#638)

Summary:
Pull Request resolved: #638

Pull Request resolved: #617

These flags should be off by default in Release mode, but some users may want to enable them.

This sets a convention for future options like this, which should also use `${_default_release_disabled_targets}`.
ghstack-source-id: 202924824
exported-using-ghexport

Reviewed By: digantdesai

Differential Revision: D49925195

fbshipit-source-id: 953888ddbbfa53ca0dd14305aa60233fb93243ee
@facebook-github-bot facebook-github-bot deleted the gh/dbort/29/head branch November 5, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants