-
Notifications
You must be signed in to change notification settings - Fork 607
[Core ML] Update Partitioner Test as Torch.Any Supported #6361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6361
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New FailuresAs of commit 6ea4092 with merge base 6ac19cc ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
666ac62
to
6e8112e
Compare
6e8112e
to
80b0b6c
Compare
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Any legit CI error I should address? |
I think our CI is failing internally but it doesn't show up externally...need to get that fixed than land this diff. cc: @kirklandsign |
No good workaround for this... |
@YifanShenSZ this test seems failing
|
Passed on my local. What's the error you saw? Just rebased, let's try again |
80b0b6c
to
6ea4092
Compare
Ah acutally I may know why - the internal test probably runs with the old coreml package |
Hmmm, how come? This PR also updates the pinned coremltools to 8.1, so if CI builds executorch & delegate from source then it should be using the latest? |
Internally we pointed to a lower version..@shoumikhin helped importing the latest coremltools, we should be able to fix it then. So no action on your side, and wait for us :) |
@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hmm it fails to import
Can you rebase? |
I've already landed this change via the internal coremltools version bump since it failed tests otherwise. |
Motivation
In #4772, the partitioner test case was updated to have graph breaks, because pytorch/pytorch#131863 introduced safe softmax which involves torch.any op that was not supported in Core ML
Solution
In coremltools 8.1 release, torch.any support has been included, so
Other Fixes
#5157 and #6201 are also resolved in coremltools 8.1