Skip to content

[Core ML] Update Partitioner Test as Torch.Any Supported #6361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

YifanShenSZ
Copy link
Collaborator

@YifanShenSZ YifanShenSZ commented Oct 18, 2024

Motivation

In #4772, the partitioner test case was updated to have graph breaks, because pytorch/pytorch#131863 introduced safe softmax which involves torch.any op that was not supported in Core ML

Solution

In coremltools 8.1 release, torch.any support has been included, so

  1. We upgrade executorch pinned coremltools to 8.1
  2. We will no longer have graph breaks in the partitioner test case

Other Fixes

#5157 and #6201 are also resolved in coremltools 8.1

Copy link

pytorch-bot bot commented Oct 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6361

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 New Failures

As of commit 6ea4092 with merge base 6ac19cc (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2024
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@YifanShenSZ
Copy link
Collaborator Author

YifanShenSZ commented Nov 20, 2024

@cccclai @shoumikhin

@YifanShenSZ YifanShenSZ marked this pull request as ready for review November 20, 2024 21:12
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@YifanShenSZ
Copy link
Collaborator Author

Any legit CI error I should address?

@cccclai
Copy link
Contributor

cccclai commented Nov 21, 2024

Any legit CI error I should address?

I think our CI is failing internally but it doesn't show up externally...need to get that fixed than land this diff. cc: @kirklandsign

@kirklandsign
Copy link
Contributor

but it doesn't show up externally

No good workaround for this...

@cccclai
Copy link
Contributor

cccclai commented Nov 21, 2024

@YifanShenSZ this test seems failing

@YifanShenSZ
Copy link
Collaborator Author

YifanShenSZ commented Nov 21, 2024

@YifanShenSZ this test seems failing

Passed on my local. What's the error you saw?

Just rebased, let's try again

@cccclai
Copy link
Contributor

cccclai commented Nov 22, 2024

Ah acutally I may know why - the internal test probably runs with the old coreml package

@YifanShenSZ
Copy link
Collaborator Author

YifanShenSZ commented Nov 22, 2024

Ah acutally I may know why - the internal test probably runs with the old coreml package

Hmmm, how come? This PR also updates the pinned coremltools to 8.1, so if CI builds executorch & delegate from source then it should be using the latest?

@cccclai
Copy link
Contributor

cccclai commented Nov 22, 2024

Ah acutally I may know why - the internal test probably runs with the old coreml package

Hmmm, how come? This PR also updates the pinned coremltools to 8.1, so if CI builds executorch & delegate from source then it should be using the latest?

Internally we pointed to a lower version..@shoumikhin helped importing the latest coremltools, we should be able to fix it then. So no action on your side, and wait for us :)

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai
Copy link
Contributor

cccclai commented Nov 24, 2024

hmm it fails to import

    The Pull Request could not be imported cleanly from GitHub. This usually happens for one of two reasons:
    1. The Pull Request is out of date, if you rebase the PR on the latest commit on the GitHub branch and find merge conflicts this is probably the reason
    2. ShipIt is broken for this repo, check bunnylol `oss org/repo`, click on the ShipIt tab, and see if there are any alerts. Fix those and retry the import.

Can you rebase?

@shoumikhin
Copy link
Contributor

I've already landed this change via the internal coremltools version bump since it failed tests otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants