Skip to content

[executorch][serialization] Move DataSegment into shared common.fbs #6679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Nov 5, 2024

Stack from ghstack (oldest at bottom):

So that DataSegment can be shared by incoming data.fbs.

Differential Revision: D65434369

So that `DataSegment` can be shared by incoming data.fbs.

Differential Revision: [D65434369](https://our.internmc.facebook.com/intern/diff/D65434369/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6679

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4f8d9a1 with merge base dc41596 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65434369

…ommon.fbs"

So that `DataSegment` can be shared by incoming data.fbs.

Differential Revision: [D65434369](https://our.internmc.facebook.com/intern/diff/D65434369/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65434369

…ommon.fbs"

So that `DataSegment` can be shared by incoming data.fbs.

Differential Revision: [D65434369](https://our.internmc.facebook.com/intern/diff/D65434369/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Nov 12, 2024
Pull Request resolved: #6679

So that `DataSegment` can be shared by incoming data.fbs.

Update all instances of `common.fbs` with the changes.

ghstack-source-id: 253121253
@exported-using-ghexport

Differential Revision: [D65434369](https://our.internmc.facebook.com/intern/diff/D65434369/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65434369

@lucylq lucylq closed this Nov 12, 2024
@lucylq lucylq deleted the gh/lucylq/16/head branch January 24, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants