[llama-mm] Enable kv cache for MultiHeadAttention #6793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Change `MultiHeadAttention` in `extension/llm/modules` to support KV cache. Only enable eager but not export yet. Test Plan: Unit test Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6793
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e72ac0b with merge base 4947e27 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: Change `MultiHeadAttention` in `extension/llm/modules` to support KV cache. Only enable eager but not export yet. Test Plan: Unit test Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jackzhxng
approved these changes
Nov 12, 2024
larryliu0820
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
larryliu0820
added a commit
that referenced
this pull request
Nov 12, 2024
Summary: Change `MultiHeadAttention` in `extension/llm/modules` to support KV cache. Only enable eager but not export yet. Test Plan: Unit test Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ded3830 Pull Request resolved: #6793 Co-authored-by: Mengwei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Change
MultiHeadAttentioninextension/llm/modulestosupport KV cache. Only enable eager but not export yet.
Test Plan: Unit test
Reviewers:
Subscribers:
Tasks:
Tags: