[Arm][Example] Minor Script Updates #715
Conversation
✅ Deploy Preview for resplendent-gnome-14e531 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
facebook-github-bot
added
the
CLA Signed
| base_rev=00a15db3e1a188b25065d095152d701f4394cdc5 | ||
| patch_repo | ||
| fi | ||
| cd "${root_dir}/ethos-u/ethos-u-vela" |
There was a problem hiding this comment.
It looks like this was because patch_repo was leaving us in ethos-u-vela directory and so pip install . was in the right place (a clean re-run works on this stage) ; do we want to consistently sub-shell functions to prevent this kind of leak?
There was a problem hiding this comment.
sounds good. But still we don't want to make too many assumption (beyond var values) when we enter the function.
There was a problem hiding this comment.
deferring this for later
| echo "[${FUNCNAME[0]}] Generated static libraries for ExecuTorch:" | ||
| find . -name "*.a" -exec ls -al {} \; | ||
| } | ||
|
|
||
| # build Arm Baremetal executor_runner | ||
| function build_executorch_runner() { | ||
| echo "[${FUNCNAME[0]}] Generating ExecuTorch libraries" |
There was a problem hiding this comment.
I notice a few other functions do not have this diagnostic output.
There was a problem hiding this comment.
yeah we should standardize a bit more
There was a problem hiding this comment.
deferring this for later
digantdesai
force-pushed
the
script-updates
branch
from
176d890 to
b1a5484
Compare
* Faster builds for reference model * realpath dir before installing vela python package
digantdesai
force-pushed
the
script-updates
branch
from
b1a5484 to
bbb6fb3
Compare
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in b167f04. |
Summary: resolves #666 other than: - some pieces fixed in #715 - Still need to remove minimal.py and replace with generic delegated pte generation flow Pull Request resolved: #718 Reviewed By: mcr229 Differential Revision: D50100544 Pulled By: digantdesai fbshipit-source-id: 239843853a7876dceb06d92221c0d4ca89acf514
No description provided.