Merge delegate runners on Arm Baremetal #718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for resplendent-gnome-14e531 canceled.
|
digantdesai
reviewed
Oct 9, 2023
examples/arm/ethos-u-setup/core_platform/patches/0007-Executorch-Add-delegate-runner-test.patch
Show resolved
Hide resolved
digantdesai
reviewed
Oct 9, 2023
examples/arm/setup.sh
Outdated
| @@ -176,13 +176,14 @@ function setup_vela() { | |||
| # | |||
| # Prepare the Vela compiler for AoT to Ethos-U compilation | |||
| # | |||
| cd "${root_dir}/ethos-u/" | |||
| cd "${root_dir}" | |||
There was a problem hiding this comment.
Ok so I will leave as is from my PR #715, when you will rebase this will override that
digantdesai
reviewed
Oct 9, 2023
| build_executorch_runner "${pte}" "${pte_delegate}" | ||
|
|
||
| # run the app | ||
| # generate a .pte file - in this case a non-delegated one |
There was a problem hiding this comment.
curious if we want to do the loop, like below so the errors can be easily associated with the relevat PTE. Or you like two fvp outputs at the end and doing this batch style :p
for pte in $(generate_pte_file) $(generate_ethos_pte_file); do
build_executorch_runner ${pte}
run_fvp ${executor_runner}
done
|
Everything looks great. I am guessing you want to rebase on #715 and then merge this? |
digantdesai
approved these changes
Oct 9, 2023
Signed-off-by: Rob Elliott <[email protected]>
Signed-off-by: Rob Elliott <[email protected]>
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in e460259. |
robell
added
the
partner: arm
Gasoonjia
pushed a commit
that referenced
this pull request
Jul 30, 2024
* improve updown parser, and use in README.md execution * cut/paste errors * typo: true -> false * we scan each partial line, so need to suppress at partial line level :( * make it twice as nice * improved updown parsing * special handling for lines w/o option * enable run on quantization doc * handle white space before trip backtick * updates * mps test * updates * Update run-readme-pr-macos.yml Rename test to avoid babe conflict * Update run-readme-pr.yml Y * Update run-readme-pr-mps.yml 2 * typos * add updown end command * typo * move broken mps * Update parking_lot/run-readme-pr-mps.yml Co-authored-by: Eli Uriegas <[email protected]> --------- Co-authored-by: Eli Uriegas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #666 other than: