-
Notifications
You must be signed in to change notification settings - Fork 608
Reduce size of Method::parse_types #7603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of Method::parse_types #7603
Conversation
It looks like this function was big enough that inlining gave up, since I was seeing non-inlined calls to val_as_Foo() that should have been easily optimized away. Do said optimization manually. Differential Revision: [D68037113](https://our.internmc.facebook.com/intern/diff/D68037113/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7603
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5162c92 with merge base e1c0bcf ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
It looks like this function was big enough that inlining gave up, since I was seeing non-inlined calls to val_as_Foo() that should have been easily optimized away. Do said optimization manually. Differential Revision: [D68037113](https://our.internmc.facebook.com/intern/diff/D68037113/) ghstack-source-id: 260959235 Pull Request resolved: #7603
This pull request was exported from Phabricator. Differential Revision: D68037113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Apply the same technique as #7603 to Method::init Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/) [ghstack-poisoned]
Apply the same technique as #7603 to Method::init Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/) ghstack-source-id: 260974726 Pull Request resolved: #7608
6361ae5
into
gh/swolchok/129/base
* add maybe_unused where needed in size_test.cpp At least one internal build have -Werror -Wunused-variable and ExecuTorch logging disabled. Differential Revision: [D68032964](https://our.internmc.facebook.com/intern/diff/D68032964/) ghstack-source-id: 260945746 Pull Request resolved: #7602 * Reduce size of Method::parse_types It looks like this function was big enough that inlining gave up, since I was seeing non-inlined calls to val_as_Foo() that should have been easily optimized away. Do said optimization manually. Differential Revision: [D68037113](https://our.internmc.facebook.com/intern/diff/D68037113/) ghstack-source-id: 260959235 Pull Request resolved: #7603 --------- Co-authored-by: Github Executorch <[email protected]>
Apply the same technique as #7603 to Method::init Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/) ghstack-source-id: 260974726 Pull Request resolved: #7608 Co-authored-by: Github Executorch <[email protected]>
* add maybe_unused where needed in size_test.cpp At least one internal build have -Werror -Wunused-variable and ExecuTorch logging disabled. Differential Revision: [D68032964](https://our.internmc.facebook.com/intern/diff/D68032964/) ghstack-source-id: 260945746 Pull Request resolved: #7602 * Reduce size of Method::parse_types It looks like this function was big enough that inlining gave up, since I was seeing non-inlined calls to val_as_Foo() that should have been easily optimized away. Do said optimization manually. Differential Revision: [D68037113](https://our.internmc.facebook.com/intern/diff/D68037113/) ghstack-source-id: 260959235 Pull Request resolved: #7603 --------- Co-authored-by: Github Executorch <[email protected]>
Apply the same technique as #7603 to Method::init Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/) ghstack-source-id: 260974726 Pull Request resolved: #7608 Co-authored-by: Github Executorch <[email protected]>
Apply the same technique as pytorch#7603 to Method::init Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/) ghstack-source-id: 260974726 Pull Request resolved: pytorch#7608 Co-authored-by: Github Executorch <[email protected]>
Stack from ghstack (oldest at bottom):
It looks like this function was big enough that inlining gave up, since I was seeing non-inlined calls to val_as_Foo() that should have been easily optimized away. Do said optimization manually.
Differential Revision: D68037113