Skip to content

don't touch CMAKE_BUILD_ARGS in install_executorch.py #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 51 commits into from
Jan 17, 2025
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
da1df94
Update
swolchok Jan 16, 2025
e411a1e
Update
swolchok Jan 16, 2025
6e9745c
Update
swolchok Jan 16, 2025
6d65549
Update
swolchok Jan 16, 2025
ac71f8d
Update
swolchok Jan 16, 2025
00fd17d
Update
swolchok Jan 16, 2025
9a1ddde
Update
swolchok Jan 16, 2025
2063432
Update
swolchok Jan 16, 2025
cd79afd
Update
swolchok Jan 16, 2025
e76d22f
Update
swolchok Jan 16, 2025
a893391
Update
swolchok Jan 16, 2025
84b8e5f
Update
swolchok Jan 16, 2025
fd0a5b1
Update
swolchok Jan 16, 2025
bf753a8
Update
swolchok Jan 16, 2025
9158d0e
Update
swolchok Jan 16, 2025
400ec37
Update
swolchok Jan 16, 2025
cab1ad3
Update
swolchok Jan 16, 2025
1238f24
Update
swolchok Jan 16, 2025
cc87ad3
Update
swolchok Jan 16, 2025
e089ac5
Update
swolchok Jan 16, 2025
2dcdbcd
Update
swolchok Jan 16, 2025
a89792a
Update
swolchok Jan 16, 2025
a95cc8d
Update
swolchok Jan 16, 2025
27a3d64
Update
swolchok Jan 16, 2025
9ad0dcd
Update
swolchok Jan 16, 2025
1d4dfab
Update
swolchok Jan 16, 2025
ff3a43d
Update
swolchok Jan 16, 2025
f98d073
Update
swolchok Jan 16, 2025
23c60d7
Update
swolchok Jan 16, 2025
5e8be76
Update
swolchok Jan 16, 2025
23bd919
Update
swolchok Jan 16, 2025
641ca89
Update
swolchok Jan 17, 2025
57dab67
Update
swolchok Jan 17, 2025
238d145
Update
swolchok Jan 17, 2025
3f2c188
Update
swolchok Jan 17, 2025
4e5c688
Update
swolchok Jan 17, 2025
4561c6b
Update
swolchok Jan 17, 2025
c208b1f
Update
swolchok Jan 17, 2025
f2719b2
Update
swolchok Jan 17, 2025
a668582
Update
swolchok Jan 17, 2025
4b3f654
Update
swolchok Jan 17, 2025
a4f50f8
Update
swolchok Jan 17, 2025
922f051
Update
swolchok Jan 17, 2025
86e9c74
Update
swolchok Jan 17, 2025
87a4c2d
Update
swolchok Jan 17, 2025
173018e
Update
swolchok Jan 17, 2025
5ca60ad
Update
swolchok Jan 17, 2025
296e827
Update
swolchok Jan 17, 2025
b6da309
Update
swolchok Jan 17, 2025
f2b1e1d
Update
swolchok Jan 17, 2025
c788265
Update
swolchok Jan 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions install_executorch.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def main(args):

EXECUTORCH_BUILD_PYBIND = ""
CMAKE_ARGS = os.getenv("CMAKE_ARGS", "")
CMAKE_BUILD_ARGS = os.getenv("CMAKE_BUILD_ARGS", "")
use_pytorch_nightly = True

parser = argparse.ArgumentParser()
Expand Down Expand Up @@ -116,7 +115,6 @@ def main(args):
# Set environment variables
os.environ["EXECUTORCH_BUILD_PYBIND"] = EXECUTORCH_BUILD_PYBIND
os.environ["CMAKE_ARGS"] = CMAKE_ARGS
os.environ["CMAKE_BUILD_ARGS"] = CMAKE_BUILD_ARGS

# Run the pip install command
subprocess.run(
Expand Down
Loading