Skip to content

Arm backend: Check memory allocation on target #9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Arm backend: Check memory allocation on target #9735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 69 additions & 34 deletions examples/arm/executor_runner/arm_executor_runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ Result<BufferCleanup> prepare_input_tensors(

void** inputs =
static_cast<void**>(allocator.allocate(num_inputs * sizeof(void*)));

ET_CHECK_OR_RETURN_ERROR(
inputs != nullptr,
MemoryAllocationFailed,
Expand Down Expand Up @@ -349,15 +348,19 @@ std::pair<char*, size_t> read_binary_file(
"Could not open file %s (errno: %d) for reading, exiting!",
filename,
errno);
_exit(1);
return std::make_pair(nullptr, 0);
}

fseek(fp, 0, SEEK_END);
auto file_size = ftell(fp);
fseek(fp, 0, SEEK_SET);

char* buffer = static_cast<char*>(allocator.allocate(file_size));

if (buffer == nullptr) {
ET_LOG(
Fatal, "Failed to allocate input file size:%zu", (uint32_t)file_size);
return std::make_pair(nullptr, 0);
}
auto read_size = fread(buffer, 1, file_size, fp);
if (read_size != file_size) {
ET_LOG(
Expand Down Expand Up @@ -415,12 +418,28 @@ int main(int argc, const char* argv[]) {
input_tensor_filename);
auto [buffer, buffer_size] =
read_binary_file(input_tensor_filename, input_file_allocator);
if (buffer == nullptr) {
ET_LOG(
Error,
"Reading input tensor %d from file %s ERROR Out of memory",
nbr_inputs,
input_tensor_filename);
_exit(1);
}
input_buffers.push_back(std::make_pair(buffer, buffer_size));
} else if (std::strcmp(argv[i], "-m") == 0) {
const char* pte_filename = argv[++i];
ET_LOG(Info, "Reading pte model from file %s", pte_filename);
auto [buffer, buffer_size] =
read_binary_file(pte_filename, input_file_allocator);
if (buffer == nullptr) {
ET_LOG(
Error,
"Reading pte model from file %s ERROR Out of memory",
pte_filename);
_exit(1);
}

// Store the model data with the same variable as if it was loaded
// from compiled in location.
model_pte = buffer;
Expand Down Expand Up @@ -510,6 +529,10 @@ int main(int argc, const char* argv[]) {
/* Move to it's own allocator when MemoryPlanner is in place. */
uint8_t* buffer =
reinterpret_cast<uint8_t*>(method_allocator.allocate(buffer_size));
ET_CHECK_MSG(
buffer != nullptr,
"Could not allocate memory for memory planned buffer size %zu",
buffer_size);
planned_buffers.push_back(buffer);
planned_spans.push_back({planned_buffers.back(), buffer_size});
}
Expand Down Expand Up @@ -623,6 +646,7 @@ int main(int argc, const char* argv[]) {
ET_LOG(Info, "Starting the model execution...");
size_t executor_membase = method_allocator.used_size();
StartMeasurements();
// Run the model.
Error status = method->execute();
StopMeasurements();
size_t executor_memsize = method_allocator.used_size() - executor_membase;
Expand Down Expand Up @@ -680,6 +704,7 @@ int main(int argc, const char* argv[]) {
status = method->get_outputs(outputs.data(), outputs.size());
ET_CHECK(status == Error::Ok);

// Print the outputs.
for (int i = 0; i < outputs.size(); ++i) {
Tensor t = outputs[i].toTensor();
#if !defined(SEMIHOSTING)
Expand Down Expand Up @@ -722,31 +747,10 @@ int main(int argc, const char* argv[]) {
#endif
}

#if defined(ET_BUNDLE_IO)
if (bundle_io) {
// Verify the result.
status = executorch::bundled_program::verify_method_outputs(
*method, model_pte, testset_idx, et_rtol, et_atol);
if (status == Error::Ok) {
ET_LOG(Info, "Model output match expected BundleIO bpte ref data.");
ET_LOG(Info, "TEST: BundleIO index[%d] Test_result: PASS", testset_idx);
} else {
ET_LOG(
Error,
"Model output don't match expected BundleIO bpte ref data. rtol=%f atol=%f",
et_rtol,
et_atol);
ET_LOG(Error, "TEST: BundleIO index[%d] Test_result: FAIL", testset_idx);
}
ET_CHECK_MSG(
status == Error::Ok,
"Bundle verification failed with status 0x%" PRIx32,
status);
}
#endif

#if defined(ET_EVENT_TRACER_ENABLED)
#if !defined(SEMIHOSTING)
// Dump the etdump data containing profiling/debugging data to the serial line
// base64 encoded
ETDumpResult result = etdump_gen.get_etdump_data();
if (result.buf != nullptr && result.size > 0) {
// On a device with no file system we can't just write it out
Expand All @@ -756,15 +760,24 @@ int main(int argc, const char* argv[]) {
size_t encoded_len = base64_encoded_size(result.size, mode);
uint8_t* encoded_buf =
reinterpret_cast<uint8_t*>(method_allocator.allocate(encoded_len + 1));
int ret = base64_encode(
encoded_buf, (uint8_t*)result.buf, &encoded_len, &len, mode);
encoded_buf[encoded_len] = 0x00; // Ensure null termination
ET_LOG(Info, "Writing etdump.bin [base64]");
printf(
"#---\nbase64 -i -d <<<\"\\\n%s\\\n\" >etdump.bin\npython3 -m devtools.inspector.inspector_cli --etdump_path etdump.bin --source_time_scale cycles --target_time_scale cycles\n#---\n",
encoded_buf);
if (encoded_buf != nullptr) {
int ret = base64_encode(
encoded_buf, (uint8_t*)result.buf, &encoded_len, &len, mode);
encoded_buf[encoded_len] = 0x00; // Ensure null termination
ET_LOG(Info, "Writing etdump.bin [base64]");
printf(
"#---\nbase64 -i -d <<<\"\\\n%s\\\n\" >etdump.bin\npython3 -m devtools.inspector.inspector_cli --etdump_path etdump.bin --source_time_scale cycles --target_time_scale cycles\n#---\n",
encoded_buf);
} else {
ET_LOG(
Error,
"Could not allocate memory etdump base64 encoding size %zu",
encoded_len + 1);
}
}
#else
// Dump the etdump data containing profiling/debugging data to the specified
// file.
etdump_result result = etdump_gen.get_etdump_data();
if (result.buf != nullptr && result.size > 0) {
// On a device with a file system we can just write it out
Expand All @@ -779,7 +792,29 @@ int main(int argc, const char* argv[]) {
#endif
#endif

out:
#if defined(ET_BUNDLE_IO)
if (bundle_io) {
// Verify the result.
status = executorch::bundled_program::verify_method_outputs(
*method, model_pte, testset_idx, et_rtol, et_atol);
if (status == Error::Ok) {
ET_LOG(Info, "Model output match expected BundleIO bpte ref data.");
ET_LOG(Info, "TEST: BundleIO index[%d] Test_result: PASS", testset_idx);
} else {
ET_LOG(
Error,
"Model output don't match expected BundleIO bpte ref data. rtol=%f atol=%f",
et_rtol,
et_atol);
ET_LOG(Error, "TEST: BundleIO index[%d] Test_result: FAIL", testset_idx);
}
ET_CHECK_MSG(
status == Error::Ok,
"Bundle verification failed with status 0x%" PRIx32,
status);
}
#endif

ET_LOG(Info, "Program complete, exiting.");
#if defined(SEMIHOSTING)
_exit(0);
Expand Down
Loading