Skip to content

Revert "Embedding quantization per backend" #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

Revert "Embedding quantization per backend" #411

merged 1 commit into from
Apr 23, 2024

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Apr 23, 2024 •
edited
Loading

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2024
orionr
orionr approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it makes CI more green let's do it

mikekgfb
mikekgfb approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@malfet malfet merged commit 8b35acd into main Apr 23, 2024
mikekgfb added a commit that referenced this pull request Apr 23, 2024
@mikekgfb
Revert "Revert "Embedding quantization per backend (#402)" (#411)"
9508897 
This reverts commit 8b35acd.
@mikekgfb mikekgfb mentioned this pull request Apr 23, 2024
Merged
mikekgfb added a commit that referenced this pull request Apr 23, 2024
@mikekgfb
Revert "Revert "Embedding quantization per backend"" (#415)
8d121ae 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
mikekgfb added a commit that referenced this pull request Apr 24, 2024
@mikekgfb
Merge lowering of gguf files with ET tests into pull.yml (#417)
2294882 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* merge GGUF tests into pull.yml
@malfet malfet deleted the revert-402-embedding_quantization_per_backend branch April 30, 2024 16:49
malfet added a commit that referenced this pull request Jul 17, 2024
@malfet
Revert "Embedding quantization per backend (#402)" (#411)
cc5361c 
This reverts commit 052fb1a to  fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
f3cc50a 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Merge lowering of gguf files with ET tests into pull.yml (#417)
190e536 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* merge GGUF tests into pull.yml
malfet added a commit that referenced this pull request Jul 17, 2024
@malfet
Revert "Embedding quantization per backend (#402)" (#411)
6678cb1 
This reverts commit 052fb1a to  fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
b310fea 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Merge lowering of gguf files with ET tests into pull.yml (#417)
38bc9f2 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* merge GGUF tests into pull.yml
malfet added a commit that referenced this pull request Jul 17, 2024
@malfet
Revert "Embedding quantization per backend (#402)" (#411)
71113cf 
This reverts commit 052fb1a to  fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
15efcfa 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Merge lowering of gguf files with ET tests into pull.yml (#417)
2ae2e8a 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* merge GGUF tests into pull.yml
malfet added a commit that referenced this pull request Jul 17, 2024
@malfet
Revert "Embedding quantization per backend (#402)" (#411)
1f46052 
This reverts commit 052fb1a to  fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
b101af4 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Merge lowering of gguf files with ET tests into pull.yml (#417)
ecee04e 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* merge GGUF tests into pull.yml
malfet added a commit that referenced this pull request Jul 17, 2024
@malfet
Revert "Embedding quantization per backend (#402)" (#411)
426f405 
This reverts commit 052fb1a to  fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
971b1d0 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Merge lowering of gguf files with ET tests into pull.yml (#417)
458582a 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* merge GGUF tests into pull.yml
malfet added a commit that referenced this pull request Jul 17, 2024
@malfet
Revert "Embedding quantization per backend (#402)" (#411)
0f69590 
This reverts commit 052fb1a to  fix [test-tinystories-executorch](https://github.com/pytorch/torchchat/actions/runs/8802811768/job/24159454773?pr=411#logs)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
46bad0e 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Merge lowering of gguf files with ET tests into pull.yml (#417)
a99dc12 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* merge GGUF tests into pull.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orionr orionr orionr approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@mikekgfb mikekgfb mikekgfb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@malfet @orionr @larryliu0820 @mikekgfb @facebook-github-bot