Skip to content

Revert "Revert "Embedding quantization per backend"" #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2024
Merged

Revert "Revert "Embedding quantization per backend"" #415

merged 4 commits into from
Apr 23, 2024

Conversation

mikekgfb
Copy link
Contributor

Reverts #411

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2024
@mikekgfb mikekgfb requested a review from malfet April 23, 2024 17:46
malfet
malfet approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF CI is green, then sure

@mikekgfb mikekgfb merged commit 8d121ae into main Apr 23, 2024
@malfet malfet deleted the revert-411-revert-402-embedding_quantization_per_backend branch April 30, 2024 16:50
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
f3cc50a 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
b310fea 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
15efcfa 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
b101af4 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
971b1d0 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
malfet pushed a commit that referenced this pull request Jul 17, 2024
@mikekgfb @malfet
Revert "Revert "Embedding quantization per backend"" (#415)
46bad0e 
* Revert "Revert "Embedding quantization per backend (#402)" (#411)"

This reverts commit 8b35acd.

* 4b and 8b embedding table quantization

* minor changes

* remove extra et workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikekgfb @malfet @facebook-github-bot