Update install_requirements.sh #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/884
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled JobAs of commit c421cd2 with merge base b6b6c1e ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
approved these changes
Jul 9, 2024
byjlw
approved these changes
Jul 9, 2024
|
Manually merging given pre-existing test failure Attempting fix in #887 |
fduwjj
pushed a commit
that referenced
this pull request
Jul 11, 2024
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env. Change to use $PYTHON_EXECUTABLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current install_requirements.sh statically uses python3 to check python version; however, python3 may not exist in user's env and we may not use python3 during installation. Change to use $PYTHON_EXECUTABLE instead.