Update et-pin.txt #887
Merged
Update et-pin.txt #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Pin for ET to 2024-07-01 nightly release
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/887
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 48c2f9d with merge base b6b6c1e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 9, 2024
Gasoonjia
reviewed
Jul 10, 2024
| @@ -203,9 +203,9 @@ float* forward(Transformer* transformer, int token, int pos) { | |||
| .to(torch::kCPU); | |||
| auto logits = result[0].data_ptr(); | |||
| #else // __ET_MODEL__ | |||
| ManagedTensor pos_managed(pos_buffer, sizeof(int64_t), {1}, ScalarType::Long); | |||
| ManagedTensor pos_managed(pos_buffer, {1}, ScalarType::Long); | |||
There was a problem hiding this comment.
Why update this? Does new ET have new api interface?
There was a problem hiding this comment.
yup ET got rid of it months ago
Gasoonjia
approved these changes
Jul 10, 2024
fduwjj
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Update et-pin.txt Updating Pin for ET to 2024-07-01 nightly release * Update ManagedTensor to reflect the new API
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Update et-pin.txt Updating Pin for ET to 2024-07-01 nightly release * Update ManagedTensor to reflect the new API
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Update et-pin.txt Updating Pin for ET to 2024-07-01 nightly release * Update ManagedTensor to reflect the new API
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Update et-pin.txt Updating Pin for ET to 2024-07-01 nightly release * Update ManagedTensor to reflect the new API
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Update et-pin.txt Updating Pin for ET to 2024-07-01 nightly release * Update ManagedTensor to reflect the new API
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Update et-pin.txt Updating Pin for ET to 2024-07-01 nightly release * Update ManagedTensor to reflect the new API
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Update et-pin.txt Updating Pin for ET to 2024-07-01 nightly release * Update ManagedTensor to reflect the new API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Pin for ET to 2024-07-01 nightly release