Cleaning up --help: Gate Evaluation Arguments #885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current --help is a mess; it uses a giant
add_arguments_for_verb
function that doesn't actually filter based on the provided verb subcommand.This PR is part of a series to clean up this behavior.
Specifically, this PR restricts args that are utilized solely for perplexity evaluation to just the
eval
subcommand.Eval
still has args that are unrelated toeval
. This is addressed laterpython3 torchchat.py generate --help
python3 torchchat.py eval --help
Notice how tasks, max-seq-length, and limit only show up as args for eval