Move compile prefill out of generator parser to generic arg #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Khuu
requested review from
byjlw,
larryliu0820,
lucylq,
Gasoonjia and
vmpuri
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/892
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 603f666 with merge base 03ea37b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
byjlw
approved these changes
Jul 11, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move Compile Prefill Out of being generation specific * fix typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move Compile Prefill Out of being generation specific * fix typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move Compile Prefill Out of being generation specific * fix typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move Compile Prefill Out of being generation specific * fix typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move Compile Prefill Out of being generation specific * fix typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Move Compile Prefill Out of being generation specific * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile Prefill is only used for generation, but there is currently legacy logic that checks for this field outside of a generation context. Moved back to a generic parser arg to unblock for testing until arg_init is cleaned up