Skip to content

Move compile prefill out of generator parser to generic arg #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Move compile prefill out of generator parser to generic arg #892

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4616949
Move Compile Prefill Out of being generation specific
Jack-Khuu Jul 11, 2024
603f666
fix typo
Jack-Khuu Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ def add_arguments_for_verb(parser, verb: str) -> None:
action="store_true",
help="Whether to compile the model with torch.compile",
)
parser.add_argument(
"--compile-prefill",
action="store_true",
help="Whether to compile the prefill. Improves prefill perf, but has higher compile times.",
)
parser.add_argument(
"--profile",
type=Path,
Expand Down Expand Up @@ -301,11 +306,6 @@ def _add_generation_args(parser) -> None:
generator_parser.add_argument(
"--temperature", type=float, default=0.8, help="Temperature for sampling"
)
generator_parser.add_argument(
"--compile-prefill",
action="store_true",
help="Whether to compile the prefill. Improves prefill perf, but has higher compile times.",
)
generator_parser.add_argument(
"--sequential-prefill",
action="store_true",
Expand Down
Loading