Better variable names for scanFileAndUpdateMetadataAndIndex
#454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Jan 20, 2025
| for (size_t i = 0; i < containerMetadata_.streams.size(); ++i) { | ||
| auto& streamMetadata = containerMetadata_.streams[i]; | ||
| auto stream = formatContext_->streams[i]; | ||
| for (size_t streamIndex = 0; streamIndex < containerMetadata_.streams.size(); |
There was a problem hiding this comment.
also renamed i to streamIndex since streamIndex is already (and properly) used just above, and just below.
scotts
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
scanFileAndUpdateMetadataAndIndex, we use the variable namestreamto denote 3 different kinds of objects:StreamMetadataAVStreamStreamInfoI personally find this particularly confusing when reading the code, because this forces me to look at the variable declaration (in the best case), or at the function declaration (when
autois used) to figure out what the type is.This PR renames the single
streamname into:streamMetadataavStreamstreamInfoI propose to align the entire code-base to these names (for future PRs).