-
Notifications
You must be signed in to change notification settings - Fork 45
Align variable and type names across the codebase #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Nicolas Hug <[email protected]>
I prefer |
CPU jobs are failling with an unrelated dep-related issue. All GPU jobs are compiling and running the tests, so this is good to land. Thanks for the review! |
Needs #440 to be merged first.
This is the continuation of #454, extending it to the whole codebase. This PR renames types and variable names to make them more consistent, and to make it more obvious what they refer to. Specifically:
streamInfo
forStreamInfo
structsavStream
forAVStream
structsstreamIndex
for stream indices (instead ofstreamNumber
)avFrame
forAVFrame
structsstreamMetadata
forStreamMetadata
objectsstreams_
field ofContainerMetadata
intostreamMetadatas
. Thes
at the end feels a bit weird. Maybe this should bestreamsMetadata
, but that would be inconsistent with other similar vec fields, likeStreamInfos
(where the s is at the end). No strong opinion.VideoStreamDecoderOptions
intoVideoStreamOptions
videoStreamOptions
forVideoStreamOptions
structs instead of justoptions
. I realized the option were per-stream, not per-decoder (as I previously assumed, since this is what it's like in Python).