Skip to content

remove recommendation to specify SystemRequirements: C++11 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

romainfrancois
Copy link
Collaborator

closes #314

@romainfrancois romainfrancois mentioned this pull request Jun 27, 2023
21 tasks
Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although I am not expert on all the various places this could have been mentioned).

@romainfrancois romainfrancois requested a review from ateucher June 27, 2023 16:57
@romainfrancois
Copy link
Collaborator Author

cc @ateucher this was based on your article: https://www.tidyverse.org/blog/2023/03/cran-checks-compiled-code/#note-regarding-systemrequirements-c11

Copy link

@ateucher ateucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romainfrancois - the advice in that article was summarized from several internal Slack conversations as well as some discussions on R-pkg-devel, and I think has probably had enough road testing by now by to be considered pretty robust. Is there anywhere in the docs to say that there may be instances where authors do need to specify the C++ standard in SystemRequirements, if they are using features of a particular C++ standard?

I also wonder if it's worth clarifying somewhere that authors aren't bound to C++11 when using cpp11 (i.e., to circumvent questions like #7 and #100).

@romainfrancois
Copy link
Collaborator Author

Thanks @ateucher. I will leave that to @DavisVaughan for future versions, in the interest of releasing this week.

@romainfrancois romainfrancois merged commit 44676ca into main Jun 28, 2023
@romainfrancois romainfrancois deleted the system_requirements_update branch June 28, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify the necessary "move" w.r.t. SystemRequirements: C++11
3 participants