Skip to content

remove recommendation to specify SystemRequirements: C++11 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2023
Merged

remove recommendation to specify SystemRequirements: C++11 #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ To add cpp11 to an existing package, put your C++ files in the `src/` directory

```
LinkingTo: cpp11
SystemRequirements: C++11
```

Then decorate C++ functions you want to expose to R with `[[cpp11::register]]`.
Expand Down
1 change: 0 additions & 1 deletion cpp11test/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,4 @@ Suggests:
xml2
LazyData: true
Roxygen: list(markdown = TRUE)
SystemRequirements: C++11
RoxygenNote: 7.1.1
1 change: 0 additions & 1 deletion vignettes/converting.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ void foo() {
## Mechanics of converting a package from Rcpp

1. Add cpp11 to `LinkingTo`
1. Add C++11 to `SystemRequirements`
1. Convert all instances of `// [[Rcpp::export]]` to `[[cpp11::register]]`
1. Clean and recompile the package, e.g. `pkgbuild::clean_dll()` `pkgload::load_all()`
1. Run tests `devtools::test()`
Expand Down
1 change: 0 additions & 1 deletion vignettes/cpp11.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,6 @@ Then add the following to your `DESCRIPTION` file:

```
LinkingTo: cpp11
SystemRequirements: C++11
```

and add the following [roxygen](https://roxygen2.r-lib.org/) directive somewhere in your package's R files. (A common location is `R/pkgname-package.R`)
Expand Down